LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Mark@sirena.org.uk, Brown@sirena.org.uk, broonie@kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	open list <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	liam.r.girdwood@linux.intel.com, Jaroslav Kysela <perex@perex.cz>,
	vkoul@kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	tiwai@suse.de
Subject: Re: [RFC PATCH 1/2] ASoC: soc-pcm: protect BE dailink state changes in trigger
Date: Thu, 26 Aug 2021 19:30:24 +0100	[thread overview]
Message-ID: <163000225499.699341.16303629557242399115.b4-ty@kernel.org> (raw)
In-Reply-To: <20210817164054.250028-2-pierre-louis.bossart@linux.intel.com>

From: Mark Brown,,, <broonie@kernel.org>

On Tue, 17 Aug 2021 11:40:53 -0500, Pierre-Louis Bossart wrote:
> When more than one FE is connected to a BE, e.g. in a mixing use case,
> the BE can be triggered multiple times when the FE are opened/started
> concurrently. This race condition is problematic in the case of
> SoundWire BE dailinks, and this is not desirable in a general
> case. The code carefully checks when the BE can be stopped or
> hw_free'ed, but the trigger code does not use any mutual exclusion.
> 
> [...]

Applied, thanks!

[1/2] ASoC: soc-pcm: protect BE dailink state changes in trigger
      commit: 0c75fc7193387776c10f7c7b440d93496e3d5e21
[2/2] ASoC: soc-pcm: test refcount before triggering
      commit: 6479f7588651cbc9c91e61c20ff39119cbc8feba

Best regards,
-- 
Mark Brown,,, <broonie@kernel.org>

  reply	other threads:[~2021-08-26 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210817164054.250028-1-pierre-louis.bossart@linux.intel.com>
2021-08-17 16:40 ` Pierre-Louis Bossart
2021-08-26 18:30   ` Mark Brown [this message]
2021-08-26 19:24     ` Pierre-Louis Bossart
2021-08-30 11:15       ` Mark Brown
2021-08-17 16:40 ` [RFC PATCH 2/2] ASoC: soc-pcm: test refcount before triggering Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163000225499.699341.16303629557242399115.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=Brown@sirena.org.uk \
    --cc=Mark@sirena.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    --subject='Re: [RFC PATCH 1/2] ASoC: soc-pcm: protect BE dailink state changes in trigger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).