LKML Archive on
help / color / mirror / Atom feed
* [PATCH] afs: Fix missing put on afs_read objects on missing get on the key therein
@ 2021-08-27 22:39 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2021-08-27 22:39 UTC (permalink / raw)
  To: marc.dionne; +Cc: linux-afs, linux-fsdevel, linux-kernel

The afs_read objects created by afs_req_issue_op() get leaked because
afs_alloc_read() returns a ref and then afs_fetch_data() gets its own ref
which is released when the operation completes, but the initial ref is
never released.

Fix this by discarding the initial ref at the end of afs_req_issue_op().

This leak also covered another bug whereby a ref isn't got on the key
attached to the read record by afs_req_issue_op().  This isn't a problem as
long as the afs_read req never goes away...

Fix this by calling key_get() in afs_req_issue_op().

This was found by the generic/047 test.  It leaks ~4GiB of RAM each time it
is run.

Fixes: f7605fa869cf ("afs: Fix leak of afs_read objects")
Reported-by: Marc Dionne <>
Signed-off-by: David Howells <>

 fs/afs/file.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/afs/file.c b/fs/afs/file.c
index db035ae2a134..6688fff14b0b 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -295,7 +295,7 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
 	fsreq->subreq	= subreq;
 	fsreq->pos	= subreq->start + subreq->transferred;
 	fsreq->len	= subreq->len   - subreq->transferred;
-	fsreq->key	= subreq->rreq->netfs_priv;
+	fsreq->key	= key_get(subreq->rreq->netfs_priv);
 	fsreq->vnode	= vnode;
 	fsreq->iter	= &fsreq->def_iter;
@@ -304,6 +304,7 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
 			fsreq->pos, fsreq->len);
 	afs_fetch_data(fsreq->vnode, fsreq);
+	afs_put_read(fsreq);
 static int afs_symlink_readpage(struct page *page)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-27 22:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 22:39 [PATCH] afs: Fix missing put on afs_read objects on missing get on the key therein David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).