LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] platform/chrome: cros_ec_trace: Fix format warnings
@ 2021-08-30 18:00 Gwendal Grignou
  2021-08-31  0:28 ` Benson Leung
  0 siblings, 1 reply; 2+ messages in thread
From: Gwendal Grignou @ 2021-08-30 18:00 UTC (permalink / raw)
  To: bleung, enric.balletbo, groeck; +Cc: linux-kernel, Gwendal Grignou

Fix printf format issues in new tracing events.

Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
Changes since v2:
- Use %u instead of %d for sample timestamp it is presented as a u32 as
  well.
- Use %u instead of %d for ec_sensor_num, index is unsigned.
Changes since v1:
- Use %u instead of %d for ec timestamp, it is presented as a u32.

 drivers/platform/chrome/cros_ec_trace.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
index f50b9f9b8610..7e7cfc98657a 100644
--- a/drivers/platform/chrome/cros_ec_trace.h
+++ b/drivers/platform/chrome/cros_ec_trace.h
@@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
 		__entry->current_time = current_time;
 		__entry->delta = current_timestamp - current_time;
 	),
-	TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
+	TP_printk("ec_ts: %9u, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
 		  __entry->ec_sample_timestamp,
 		__entry->ec_fifo_timestamp,
 		__entry->fifo_timestamp,
@@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
 		__entry->current_time = current_time;
 		__entry->delta = current_timestamp - current_time;
 	),
-	TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
+	TP_printk("ec_num: %4u, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
 		  __entry->ec_sensor_num,
 		__entry->ec_fifo_timestamp,
 		__entry->fifo_timestamp,
@@ -153,7 +153,7 @@ TRACE_EVENT(cros_ec_sensorhub_filter,
 		__entry->x = state->x_offset;
 		__entry->y = state->y_offset;
 	),
-	TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
+	TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %lld x: %12lld y: %12lld",
 		  __entry->dx,
 		__entry->dy,
 		__entry->median_m,
-- 
2.33.0.259.gc128427fd7-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] platform/chrome: cros_ec_trace: Fix format warnings
  2021-08-30 18:00 [PATCH v3] platform/chrome: cros_ec_trace: Fix format warnings Gwendal Grignou
@ 2021-08-31  0:28 ` Benson Leung
  0 siblings, 0 replies; 2+ messages in thread
From: Benson Leung @ 2021-08-31  0:28 UTC (permalink / raw)
  To: Gwendal Grignou, groeck, enric.balletbo; +Cc: linux-kernel, bleung

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Gwendal,

On Mon, 30 Aug 2021 11:00:50 -0700, Gwendal Grignou wrote:
> Fix printf format issues in new tracing events.
> 
> Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")

Applied, thanks!

[1/1] platform/chrome: cros_ec_trace: Fix format warnings
      commit: cf7f3ebb41d809c143f22a2fc518d16f1d995c0b

Best regards,
-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-31  0:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 18:00 [PATCH v3] platform/chrome: cros_ec_trace: Fix format warnings Gwendal Grignou
2021-08-31  0:28 ` Benson Leung

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).