LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net/sun3_82586: Fix return value of sun3_82586_probe()
@ 2021-09-01 12:17 Geert Uytterhoeven
2021-09-02 10:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-09-01 12:17 UTC (permalink / raw)
To: Arnd Bergmann, David S . Miller, Jakub Kicinski
Cc: Sam Creasey, netdev, linux-m68k, linux-kernel, Geert Uytterhoeven
drivers/net/ethernet/i825xx/sun3_82586.c: In function ‘sun3_82586_probe’:
drivers/net/ethernet/i825xx/sun3_82586.c:317:9: warning: returning ‘struct net_device *’ from a function with return type ‘int’ makes integer from pointer without a cast [-Wint-conversion]
317 | return dev;
| ^~~
The return type of sun3_82586_probe() was changed, but one return value
was forgotten to be updated.
Fixes: e179d78ee11a70e2 ("m68k: remove legacy probing")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/i825xx/sun3_82586.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/i825xx/sun3_82586.c b/drivers/net/ethernet/i825xx/sun3_82586.c
index 8c57e6e36647e9d3..ec4c5cfe2d68e8ed 100644
--- a/drivers/net/ethernet/i825xx/sun3_82586.c
+++ b/drivers/net/ethernet/i825xx/sun3_82586.c
@@ -314,7 +314,7 @@ static int __init sun3_82586_probe(void)
err = register_netdev(dev);
if (err)
goto out2;
- return dev;
+ return 0;
out2:
release_region(ioaddr, SUN3_82586_TOTAL_SIZE);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/sun3_82586: Fix return value of sun3_82586_probe()
2021-09-01 12:17 [PATCH] net/sun3_82586: Fix return value of sun3_82586_probe() Geert Uytterhoeven
@ 2021-09-02 10:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-02 10:40 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: arnd, davem, kuba, sammy, netdev, linux-m68k, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 1 Sep 2021 14:17:35 +0200 you wrote:
> drivers/net/ethernet/i825xx/sun3_82586.c: In function ‘sun3_82586_probe’:
> drivers/net/ethernet/i825xx/sun3_82586.c:317:9: warning: returning ‘struct net_device *’ from a function with return type ‘int’ makes integer from pointer without a cast [-Wint-conversion]
> 317 | return dev;
> | ^~~
>
> The return type of sun3_82586_probe() was changed, but one return value
> was forgotten to be updated.
>
> [...]
Here is the summary with links:
- net/sun3_82586: Fix return value of sun3_82586_probe()
https://git.kernel.org/netdev/net/c/66abf5fb4cf7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-02 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 12:17 [PATCH] net/sun3_82586: Fix return value of sun3_82586_probe() Geert Uytterhoeven
2021-09-02 10:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).