LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] ipv6: change return type from int to void for mld_process_v2
@ 2021-09-01 15:34 Jiwon Kim
2021-09-02 10:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiwon Kim @ 2021-09-01 15:34 UTC (permalink / raw)
To: davem; +Cc: yoshfuji, dsahern, kuba, netdev, linux-kernel, Jiwon Kim
The mld_process_v2 only returned 0.
So, the return type is changed to void.
Signed-off-by: Jiwon Kim <jiwonaid0@gmail.com>
---
net/ipv6/mcast.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index cd951faa2fac..bed8155508c8 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -1356,8 +1356,8 @@ static int mld_process_v1(struct inet6_dev *idev, struct mld_msg *mld,
return 0;
}
-static int mld_process_v2(struct inet6_dev *idev, struct mld2_query *mld,
- unsigned long *max_delay)
+static void mld_process_v2(struct inet6_dev *idev, struct mld2_query *mld,
+ unsigned long *max_delay)
{
*max_delay = max(msecs_to_jiffies(mldv2_mrc(mld)), 1UL);
@@ -1367,7 +1367,7 @@ static int mld_process_v2(struct inet6_dev *idev, struct mld2_query *mld,
idev->mc_maxdelay = *max_delay;
- return 0;
+ return;
}
/* called with rcu_read_lock() */
@@ -1454,9 +1454,7 @@ static void __mld_query_work(struct sk_buff *skb)
mlh2 = (struct mld2_query *)skb_transport_header(skb);
- err = mld_process_v2(idev, mlh2, &max_delay);
- if (err < 0)
- goto out;
+ mld_process_v2(idev, mlh2, &max_delay);
if (group_type == IPV6_ADDR_ANY) { /* general query */
if (mlh2->mld2q_nsrcs)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: change return type from int to void for mld_process_v2
2021-09-01 15:34 [PATCH net-next] ipv6: change return type from int to void for mld_process_v2 Jiwon Kim
@ 2021-09-02 10:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-02 10:40 UTC (permalink / raw)
To: Jiwon Kim; +Cc: davem, yoshfuji, dsahern, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 2 Sep 2021 00:34:49 +0900 you wrote:
> The mld_process_v2 only returned 0.
>
> So, the return type is changed to void.
>
> Signed-off-by: Jiwon Kim <jiwonaid0@gmail.com>
> ---
> net/ipv6/mcast.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Here is the summary with links:
- [net-next] ipv6: change return type from int to void for mld_process_v2
https://git.kernel.org/netdev/net/c/3f22bb137eb0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-02 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 15:34 [PATCH net-next] ipv6: change return type from int to void for mld_process_v2 Jiwon Kim
2021-09-02 10:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).