LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ACPI/PRM: Find PRMT table before parse it
@ 2021-09-08  2:09 Aubrey Li
  2021-09-08 10:06 ` Paul Menzel
  0 siblings, 1 reply; 2+ messages in thread
From: Aubrey Li @ 2021-09-08  2:09 UTC (permalink / raw)
  To: rjw, pmenzel; +Cc: linux-acpi, linux-kernel, Aubrey Li, Aubrey Li

Find and verify PRMT table before parse it, this eliminates a
warning on machines without PRMT table.

	[    7.197173] ACPI: PRMT not present

Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/acpi/prmt.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
index 1f6007a..89c22bc 100644
--- a/drivers/acpi/prmt.c
+++ b/drivers/acpi/prmt.c
@@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
 
 void __init init_prmt(void)
 {
+	struct acpi_table_header *tbl;
 	acpi_status status;
-	int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
+	int mc;
+
+	status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
+	if (ACPI_FAILURE(status))
+		return;
+
+	mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
 					  sizeof (struct acpi_table_prmt_header),
 					  0, acpi_parse_prmt, 0);
+	acpi_put_table(tbl);
 	/*
 	 * Return immediately if PRMT table is not present or no PRM module found.
 	 */
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI/PRM: Find PRMT table before parse it
  2021-09-08  2:09 [PATCH] ACPI/PRM: Find PRMT table before parse it Aubrey Li
@ 2021-09-08 10:06 ` Paul Menzel
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Menzel @ 2021-09-08 10:06 UTC (permalink / raw)
  To: Aubrey Li; +Cc: linux-acpi, linux-kernel, Aubrey Li, Rafael J. Wysocki

Dear Aubrey,


Am 08.09.21 um 04:09 schrieb Aubrey Li:
> Find and verify PRMT table before parse it, this eliminates a
> warning on machines without PRMT table.
> 
> 	[    7.197173] ACPI: PRMT not present

Please also add:

Fixes: cefc7ca462 ("ACPI: PRM: implement OperationRegion handler for the 
PlatformRtMechanism subtype")

> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   drivers/acpi/prmt.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
> index 1f6007a..89c22bc 100644
> --- a/drivers/acpi/prmt.c
> +++ b/drivers/acpi/prmt.c
> @@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
>   
>   void __init init_prmt(void)
>   {
> +	struct acpi_table_header *tbl;
>   	acpi_status status;
> -	int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> +	int mc;
> +
> +	status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
> +	if (ACPI_FAILURE(status))
> +		return;
> +
> +	mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
>   					  sizeof (struct acpi_table_prmt_header),
>   					  0, acpi_parse_prmt, 0);
> +	acpi_put_table(tbl);
>   	/*
>   	 * Return immediately if PRMT table is not present or no PRM module found.
>   	 */

Thank you very much for preparing the patch.


Kind regards,

Paul

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-08 10:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08  2:09 [PATCH] ACPI/PRM: Find PRMT table before parse it Aubrey Li
2021-09-08 10:06 ` Paul Menzel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).