LKML Archive on
help / color / mirror / Atom feed
* [PATCH] dma: hsu: switch from 'pci_' to 'dma_' API
@ 2021-09-17  7:16 Qing Wang
  0 siblings, 0 replies; only message in thread
From: Qing Wang @ 2021-09-17  7:16 UTC (permalink / raw)
  To: Vinod Koul, dmaengine, linux-kernel; +Cc: Qing Wang

The wrappers in include/linux/pci-dma-compat.h should go away.

The patch has been generated with the coccinelle script below.
expression e1, e2;
-    pci_set_dma_mask(e1, e2)
+    dma_set_mask(&e1->dev, e2)

expression e1, e2;
-    pci_set_consistent_dma_mask(e1, e2)
+    dma_set_coherent_mask(&e1->dev, e2)

While at it, some 'dma_set_mask()/dma_set_coherent_mask()' have been
updated to a much less verbose 'dma_set_mask_and_coherent()'.

This type of patches has been going on for a long time, I plan to 
clean it up in the near future. If needed, see post from 
Christoph Hellwig on the kernel-janitors ML:

Signed-off-by: Qing Wang <>
 drivers/dma/hsu/pci.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/dma/hsu/pci.c b/drivers/dma/hsu/pci.c
index 9045a6f..6a2df3d
--- a/drivers/dma/hsu/pci.c
+++ b/drivers/dma/hsu/pci.c
@@ -65,11 +65,7 @@ static int hsu_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
-	ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
-	if (ret)
-		return ret;
-	ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
+	ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
 	if (ret)
 		return ret;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-17  7:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  7:16 [PATCH] dma: hsu: switch from 'pci_' to 'dma_' API Qing Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).