LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"
@ 2021-09-16 14:41 ` Krzysztof Kozlowski
  2021-09-17  7:30   ` Marek Szyprowski
  2021-09-17 14:03   ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 14:41 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
	Liam Girdwood, Mark Brown, Marek Szyprowski, linux-kernel

This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.

The MODULE_DEVICE_TABLE already creates proper alias.  Having another
MODULE_ALIAS causes the alias to be duplicated:

  $ modinfo max14577-regulator.ko

  alias:          platform:max77836-regulator
  alias:          platform:max14577-regulator
  description:    Maxim 14577/77836 regulator driver
  alias:          platform:max77836-regulator
  alias:          platform:max14577-regulator

Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

---

Not tested. Please test/comment.  This is an RFT also because reverted
commit said to fix autoloading issue which I even reviewed... but really
it should not be needed - alias gets duplicated.
---
 drivers/regulator/max14577-regulator.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c
index 1d78b455cc48..e34face736f4 100644
--- a/drivers/regulator/max14577-regulator.c
+++ b/drivers/regulator/max14577-regulator.c
@@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
 MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
 MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:max14577-regulator");
-MODULE_ALIAS("platform:max77836-regulator");
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"
  2021-09-16 14:41 ` [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings" Krzysztof Kozlowski
@ 2021-09-17  7:30   ` Marek Szyprowski
  2021-09-17 14:03   ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2021-09-17  7:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Chanwoo Choi, Bartlomiej Zolnierkiewicz,
	Liam Girdwood, Mark Brown, linux-kernel

Hi Krzysztof,

On 16.09.2021 16:41, Krzysztof Kozlowski wrote:
> This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.
>
> The MODULE_DEVICE_TABLE already creates proper alias.  Having another
> MODULE_ALIAS causes the alias to be duplicated:
>
>    $ modinfo max14577-regulator.ko
>
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>    description:    Maxim 14577/77836 regulator driver
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> ---
>
> Not tested. Please test/comment.  This is an RFT also because reverted
> commit said to fix autoloading issue which I even reviewed... but really
> it should not be needed - alias gets duplicated.
> ---

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Indeed, that patch was useless and excessive. It must be some leftover 
from my initial modules tests, which for good reasons was not submitted 
in the initial series in Feb 2020. Sorry for the noise.

>   drivers/regulator/max14577-regulator.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c
> index 1d78b455cc48..e34face736f4 100644
> --- a/drivers/regulator/max14577-regulator.c
> +++ b/drivers/regulator/max14577-regulator.c
> @@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
>   MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
>   MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:max14577-regulator");
> -MODULE_ALIAS("platform:max77836-regulator");

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"
  2021-09-16 14:41 ` [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings" Krzysztof Kozlowski
  2021-09-17  7:30   ` Marek Szyprowski
@ 2021-09-17 14:03   ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-09-17 14:03 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, linux-kernel,
	Marek Szyprowski, Liam Girdwood, Chanwoo Choi
  Cc: Mark Brown

On Thu, 16 Sep 2021 16:41:02 +0200, Krzysztof Kozlowski wrote:
> This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.
> 
> The MODULE_DEVICE_TABLE already creates proper alias.  Having another
> MODULE_ALIAS causes the alias to be duplicated:
> 
>   $ modinfo max14577-regulator.ko
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"
      commit: dc9660590d106bb58d145233fffca4efadad3655

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-17 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210916144119eucas1p1ef79e9742c3d37d0d896f152b4252a0b@eucas1p1.samsung.com>
2021-09-16 14:41 ` [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings" Krzysztof Kozlowski
2021-09-17  7:30   ` Marek Szyprowski
2021-09-17 14:03   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).