LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ptp: ocp: add COMMON_CLK dependency
@ 2021-09-20  9:57 Arnd Bergmann
  2021-09-20 10:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-09-20  9:57 UTC (permalink / raw)
  To: Richard Cochran, Jonathan Lemon, Jakub Kicinski
  Cc: Arnd Bergmann, David S. Miller, netdev, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without CONFIG_COMMON_CLK, this fails to link:

arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_register_i2c':
ptp_ocp.c:(.text+0xcc0): undefined reference to `__clk_hw_register_fixed_rate'
arm-linux-gnueabi-ld: ptp_ocp.c:(.text+0xcf4): undefined reference to `devm_clk_hw_register_clkdev'
arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_detach':
ptp_ocp.c:(.text+0x1c24): undefined reference to `clk_hw_unregister_fixed_rate'

Fixes: a7e1abad13f3 ("ptp: Add clock driver for the OpenCompute TimeCard.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/ptp/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index f02bedf41264..458218f88c5e 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -174,6 +174,7 @@ config PTP_1588_CLOCK_OCP
 	depends on I2C && MTD
 	depends on SERIAL_8250
 	depends on !S390
+	depends on COMMON_CLK
 	select NET_DEVLINK
 	help
 	  This driver adds support for an OpenCompute time card.
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: ocp: add COMMON_CLK dependency
  2021-09-20  9:57 [PATCH] ptp: ocp: add COMMON_CLK dependency Arnd Bergmann
@ 2021-09-20 10:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-20 10:20 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: richardcochran, jonathan.lemon, kuba, arnd, davem, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 20 Sep 2021 11:57:49 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Without CONFIG_COMMON_CLK, this fails to link:
> 
> arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_register_i2c':
> ptp_ocp.c:(.text+0xcc0): undefined reference to `__clk_hw_register_fixed_rate'
> arm-linux-gnueabi-ld: ptp_ocp.c:(.text+0xcf4): undefined reference to `devm_clk_hw_register_clkdev'
> arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_detach':
> ptp_ocp.c:(.text+0x1c24): undefined reference to `clk_hw_unregister_fixed_rate'
> 
> [...]

Here is the summary with links:
  - ptp: ocp: add COMMON_CLK dependency
    https://git.kernel.org/netdev/net/c/42a99a0be307

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-20 10:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20  9:57 [PATCH] ptp: ocp: add COMMON_CLK dependency Arnd Bergmann
2021-09-20 10:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).