LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: vdso: remove -nostdlib compiler flag
@ 2021-11-07 16:18 Masahiro Yamada
  2021-11-08 10:37 ` Will Deacon
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-11-07 16:18 UTC (permalink / raw)
  To: Will Deacon, Catalin Marinas, linux-arm-kernel
  Cc: clang-built-linux, Masahiro Yamada, Kees Cook, Nathan Chancellor,
	Nick Desaulniers, Peter Collingbourne, Peter Zijlstra (Intel),
	Sami Tolvanen, Vincenzo Frascino, linux-kernel

The -nostdlib option requests the compiler to not use the standard
system startup files or libraries when linking. It is effective only
when $(CC) is used as a linker driver.

Since commit 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC)
to link VDSO"), $(LD) is directly used, hence -nostdlib is unneeded.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/arm64/kernel/vdso/Makefile   | 2 +-
 arch/arm64/kernel/vdso32/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
index 945e6bb326e3..700767dfd221 100644
--- a/arch/arm64/kernel/vdso/Makefile
+++ b/arch/arm64/kernel/vdso/Makefile
@@ -23,7 +23,7 @@ btildflags-$(CONFIG_ARM64_BTI_KERNEL) += -z force-bti
 # potential future proofing if we end up with internal calls to the exported
 # routines, as x86 does (see 6f121e548f83 ("x86, vdso: Reimplement vdso.so
 # preparation in build-time C")).
-ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv	\
+ldflags-y := -shared -soname=linux-vdso.so.1 --hash-style=sysv	\
 	     -Bsymbolic --build-id=sha1 -n $(btildflags-y) -T
 
 ccflags-y := -fno-common -fno-builtin -fno-stack-protector -ffixed-x18
diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
index c8fec493a450..6c01b63ff56d 100644
--- a/arch/arm64/kernel/vdso32/Makefile
+++ b/arch/arm64/kernel/vdso32/Makefile
@@ -102,7 +102,7 @@ VDSO_AFLAGS += -D__ASSEMBLY__
 # From arm vDSO Makefile
 VDSO_LDFLAGS += -Bsymbolic --no-undefined -soname=linux-vdso.so.1
 VDSO_LDFLAGS += -z max-page-size=4096 -z common-page-size=4096
-VDSO_LDFLAGS += -nostdlib -shared --hash-style=sysv --build-id=sha1
+VDSO_LDFLAGS += -shared --hash-style=sysv --build-id=sha1
 
 
 # Borrow vdsomunge.c from the arm vDSO
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: vdso: remove -nostdlib compiler flag
  2021-11-07 16:18 [PATCH] arm64: vdso: remove -nostdlib compiler flag Masahiro Yamada
@ 2021-11-08 10:37 ` Will Deacon
  0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2021-11-08 10:37 UTC (permalink / raw)
  To: Masahiro Yamada, linux-arm-kernel, Catalin Marinas
  Cc: kernel-team, Will Deacon, Peter Collingbourne, Vincenzo Frascino,
	Sami Tolvanen, Nathan Chancellor, Peter Zijlstra (Intel),
	linux-kernel, Nick Desaulniers, clang-built-linux, Kees Cook

On Mon, 8 Nov 2021 01:18:02 +0900, Masahiro Yamada wrote:
> The -nostdlib option requests the compiler to not use the standard
> system startup files or libraries when linking. It is effective only
> when $(CC) is used as a linker driver.
> 
> Since commit 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC)
> to link VDSO"), $(LD) is directly used, hence -nostdlib is unneeded.
> 
> [...]

Applied to arm64 (for-next/core), thanks!

[1/1] arm64: vdso: remove -nostdlib compiler flag
      https://git.kernel.org/arm64/c/34688c76911e

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-08 10:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 16:18 [PATCH] arm64: vdso: remove -nostdlib compiler flag Masahiro Yamada
2021-11-08 10:37 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).