LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: rockchip: remove mmc-hs400-enhanced-strobe from rk3399-khadas-edge
@ 2021-11-15  8:33 Artem Lapkin
  2021-11-21 18:52 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Artem Lapkin @ 2021-11-15  8:33 UTC (permalink / raw)
  To: heiko, linux-rockchip
  Cc: robh+dt, jbx6244, wenst, christianshewitt, devicetree,
	linux-kernel, linux-arm-kernel, art, nick, gouwa

Remove mmc-hs400-enhanced-strobe from the rk3399-khadas-edge dts to
improve compatibility with a wider range of eMMC chips.

Before (BJTD4R 29.1 GiB):

[    7.001493] mmc2: CQHCI version 5.10
[    7.027971] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc] using ADMA
.......
[    7.207086] mmc2: mmc_select_hs400es failed, error -110
[    7.207129] mmc2: error -110 whilst initialising MMC card
[    7.308893] mmc2: mmc_select_hs400es failed, error -110
[    7.308921] mmc2: error -110 whilst initialising MMC card
[    7.427524] mmc2: mmc_select_hs400es failed, error -110
[    7.427546] mmc2: error -110 whilst initialising MMC card
[    7.590993] mmc2: mmc_select_hs400es failed, error -110
[    7.591012] mmc2: error -110 whilst initialising MMC card

After:

[    6.960785] mmc2: CQHCI version 5.10
[    6.984672] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc] using ADMA
[    7.175021] mmc2: Command Queue Engine enabled
[    7.175053] mmc2: new HS400 MMC card at address 0001
[    7.175808] mmcblk2: mmc2:0001 BJTD4R 29.1 GiB
[    7.176033] mmcblk2boot0: mmc2:0001 BJTD4R 4.00 MiB
[    7.176245] mmcblk2boot1: mmc2:0001 BJTD4R 4.00 MiB
[    7.176495] mmcblk2rpmb: mmc2:0001 BJTD4R 4.00 MiB, chardev (242:0)

Signed-off-by: Artem Lapkin <art@khadas.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi | 1 -
 1 file changed, 1 deletion(-)

V2: update & tidy commit message + put testing information here
(suggested by Christian Hewitt <christianshewitt@gmail.com> )

Testing with a selection of eMMC modules shows no observable performance
difference. For example, testing with DUTA42 116 GiB & BJTD4R 29.1 GiB:

..... mmc-hs400-enhanced-strobe disabled
[    7.175053] mmc2: new HS400 MMC card at address 0001
786432000 bytes (786 MB, 750 MiB) copied, 3 s, 262 MB/s

..... mmc-hs400-enhanced-strobe enabled
[    7.135880] mmc2: Command Queue Engine enabled
[    7.135928] mmc2: new HS400 Enhanced strobe MMC card at address 0001
[    7.136992] mmcblk2: mmc2:0001 DUTA42 116 GiB
1048576000 bytes (1.0 GB, 1000 MiB) copied, 4 s, 262 MB/s

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
index d5c7648c841d..f1fcc6b5b402 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
@@ -705,7 +705,6 @@ &sdmmc {
 &sdhci {
 	bus-width = <8>;
 	mmc-hs400-1_8v;
-	mmc-hs400-enhanced-strobe;
 	non-removable;
 	status = "okay";
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: dts: rockchip: remove mmc-hs400-enhanced-strobe from rk3399-khadas-edge
  2021-11-15  8:33 [PATCH v2] arm64: dts: rockchip: remove mmc-hs400-enhanced-strobe from rk3399-khadas-edge Artem Lapkin
@ 2021-11-21 18:52 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-11-21 18:52 UTC (permalink / raw)
  To: Artem Lapkin, linux-rockchip
  Cc: Heiko Stuebner, linux-arm-kernel, gouwa, jbx6244, nick, wenst,
	linux-kernel, devicetree, christianshewitt, art, robh+dt

On Mon, 15 Nov 2021 16:33:21 +0800, Artem Lapkin wrote:
> Remove mmc-hs400-enhanced-strobe from the rk3399-khadas-edge dts to
> improve compatibility with a wider range of eMMC chips.
> 
> Before (BJTD4R 29.1 GiB):
> 
> [    7.001493] mmc2: CQHCI version 5.10
> [    7.027971] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc] using ADMA
> .......
> [    7.207086] mmc2: mmc_select_hs400es failed, error -110
> [    7.207129] mmc2: error -110 whilst initialising MMC card
> [    7.308893] mmc2: mmc_select_hs400es failed, error -110
> [    7.308921] mmc2: error -110 whilst initialising MMC card
> [    7.427524] mmc2: mmc_select_hs400es failed, error -110
> [    7.427546] mmc2: error -110 whilst initialising MMC card
> [    7.590993] mmc2: mmc_select_hs400es failed, error -110
> [    7.591012] mmc2: error -110 whilst initialising MMC card
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: remove mmc-hs400-enhanced-strobe from rk3399-khadas-edge
      commit: 6dd0053683804427529ef3523f7872f473440a19

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-21 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15  8:33 [PATCH v2] arm64: dts: rockchip: remove mmc-hs400-enhanced-strobe from rk3399-khadas-edge Artem Lapkin
2021-11-21 18:52 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).