LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion
@ 2021-10-29  0:53 Dennis Gilmore
  2021-11-01  9:46 ` Florian Klink
  2021-11-21 18:52 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Dennis Gilmore @ 2021-10-29  0:53 UTC (permalink / raw)
  To: linux-rockchip
  Cc: dgilmore, Rob Herring, Heiko Stuebner, Uwe Kleine-König,
	Florian Klink,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/Rockchip SoC support, open list

without ep-gpios defined u-boot does not initialise PCIe
rockchip_pcie pcie@f8000000: failed to find ep-gpios property

additionally set max-link-speed and pinctrl-names for completeness

with this patch and the ones from Florian Klink applied to the dts
file in u-boot sata drives show up in both u-boot and linux

Signed-off-by: Dennis Gilmore <dgilmore@redhat.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 9c2b45012daa..1e4042a7fdc3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -534,7 +534,10 @@ &pcie_phy {
 };
 
 &pcie0 {
+	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
+	max-link-speed = <2>;
 	num-lanes = <2>;
+	pinctrl-names = "default";
 	status = "okay";
 
 	vpcie12v-supply = <&vcc12v_dcin>;
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion
  2021-10-29  0:53 [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion Dennis Gilmore
@ 2021-11-01  9:46 ` Florian Klink
  2021-11-21 18:52 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Klink @ 2021-11-01  9:46 UTC (permalink / raw)
  To: Dennis Gilmore
  Cc: linux-rockchip, Rob Herring, Heiko Stuebner,
	Uwe Kleine-König,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/Rockchip SoC support, open list

Acked-By: Florian Klink <flokli@flokli.de>

On 21-10-28 19:53:19, Dennis Gilmore wrote:
>without ep-gpios defined u-boot does not initialise PCIe
>rockchip_pcie pcie@f8000000: failed to find ep-gpios property
>
>additionally set max-link-speed and pinctrl-names for completeness
>
>with this patch and the ones from Florian Klink applied to the dts
>file in u-boot sata drives show up in both u-boot and linux
>
>Signed-off-by: Dennis Gilmore <dgilmore@redhat.com>
>---
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>index 9c2b45012daa..1e4042a7fdc3 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>@@ -534,7 +534,10 @@ &pcie_phy {
> };
>
> &pcie0 {
>+	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>+	max-link-speed = <2>;
> 	num-lanes = <2>;
>+	pinctrl-names = "default";
> 	status = "okay";
>
> 	vpcie12v-supply = <&vcc12v_dcin>;
>-- 
>2.32.0

-- 
Florian Klink

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion
  2021-10-29  0:53 [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion Dennis Gilmore
  2021-11-01  9:46 ` Florian Klink
@ 2021-11-21 18:52 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2021-11-21 18:52 UTC (permalink / raw)
  To: Dennis Gilmore, linux-rockchip
  Cc: Heiko Stuebner, Uwe Kleine-König,
	moderated list:ARM/Rockchip SoC support, open list,
	Florian Klink,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Rob Herring

On Thu, 28 Oct 2021 19:53:19 -0500, Dennis Gilmore wrote:
> without ep-gpios defined u-boot does not initialise PCIe
> rockchip_pcie pcie@f8000000: failed to find ep-gpios property
> 
> additionally set max-link-speed and pinctrl-names for completeness
> 
> with this patch and the ones from Florian Klink applied to the dts
> file in u-boot sata drives show up in both u-boot and linux

Applied, thanks!

[1/1] arm64: dts: rockchip: helios64: add variables for pcie completion
      commit: 755fff528b1b760c700dbf39928ff3dda825f748

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-21 18:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29  0:53 [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion Dennis Gilmore
2021-11-01  9:46 ` Florian Klink
2021-11-21 18:52 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).