LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately
@ 2021-11-14 11:56 Jason Wang
  2021-11-25  9:36 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-11-14 11:56 UTC (permalink / raw)
  To: mpe
  Cc: benh, paulus, andrew, michael, wangborong, davem, linuxppc-dev,
	linux-kernel

EXPORT_SYMBOL(foo); should immediately follow its function/variable.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 arch/powerpc/sysdev/tsi108_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c
index 4c4a6efd5e5f..9e13fb35ed5c 100644
--- a/arch/powerpc/sysdev/tsi108_dev.c
+++ b/arch/powerpc/sysdev/tsi108_dev.c
@@ -51,13 +51,12 @@ phys_addr_t get_csrbase(void)
 	}
 	return tsi108_csr_base;
 }
+EXPORT_SYMBOL(get_csrbase);
 
 u32 get_vir_csrbase(void)
 {
 	return (u32) (ioremap(get_csrbase(), 0x10000));
 }
-
-EXPORT_SYMBOL(get_csrbase);
 EXPORT_SYMBOL(get_vir_csrbase);
 
 static int __init tsi108_eth_of_init(void)
-- 
2.33.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately
  2021-11-14 11:56 [PATCH] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately Jason Wang
@ 2021-11-25  9:36 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-11-25  9:36 UTC (permalink / raw)
  To: mpe, Jason Wang
  Cc: benh, michael, paulus, linux-kernel, davem, andrew, linuxppc-dev

On Sun, 14 Nov 2021 19:56:16 +0800, Jason Wang wrote:
> EXPORT_SYMBOL(foo); should immediately follow its function/variable.
> 
> 

Applied to powerpc/next.

[1/1] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately
      https://git.kernel.org/powerpc/c/a3bcfc182b2c968fd740101322bd128844724961

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-25  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-14 11:56 [PATCH] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately Jason Wang
2021-11-25  9:36 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).