LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/2] Remove USB2 nodes from SC7280 IDP common dtsi file
@ 2021-11-25 10:56 Sandeep Maheswaram
  2021-11-25 10:56 ` [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Sandeep Maheswaram
  2021-11-25 10:56 ` [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board Sandeep Maheswaram
  0 siblings, 2 replies; 6+ messages in thread
From: Sandeep Maheswaram @ 2021-11-25 10:56 UTC (permalink / raw)
  To: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, Matthias Kaehlcke
  Cc: devicetree, linux-arm-msm, linux-kernel, quic_pkondeti,
	quic_ppratap, Sandeep Maheswaram

Remove USB2 controller and phy nodes from common dtsi file as it is
required only for SKU1 board.
Add these nodes in SKU1 dtsi file.

Sandeep Maheswaram (2):
  arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common
    dtsi
  arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board

 arch/arm64/boot/dts/qcom/sc7280-idp.dts  | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 16 ----------------
 2 files changed, 16 insertions(+), 16 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi
  2021-11-25 10:56 [PATCH 0/2] Remove USB2 nodes from SC7280 IDP common dtsi file Sandeep Maheswaram
@ 2021-11-25 10:56 ` Sandeep Maheswaram
  2021-11-29 18:02   ` Matthias Kaehlcke
  2021-11-25 10:56 ` [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board Sandeep Maheswaram
  1 sibling, 1 reply; 6+ messages in thread
From: Sandeep Maheswaram @ 2021-11-25 10:56 UTC (permalink / raw)
  To: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, Matthias Kaehlcke
  Cc: devicetree, linux-arm-msm, linux-kernel, quic_pkondeti,
	quic_ppratap, Sandeep Maheswaram

Remove USB2 controller and phy nodes from common dtsi file as it is
required only for SKU1 board.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index d623d71..c54ad62 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -398,22 +398,6 @@
 	vdda-pll-supply = <&vreg_l1b_0p8>;
 };
 
-&usb_2 {
-	status = "okay";
-};
-
-&usb_2_dwc3 {
-	dr_mode = "peripheral";
-};
-
-&usb_2_hsphy {
-	status = "okay";
-
-	vdda-pll-supply = <&vreg_l10c_0p8>;
-	vdda33-supply = <&vreg_l2b_3p0>;
-	vdda18-supply = <&vreg_l1c_1p8>;
-};
-
 &uart7 {
 	status = "okay";
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board
  2021-11-25 10:56 [PATCH 0/2] Remove USB2 nodes from SC7280 IDP common dtsi file Sandeep Maheswaram
  2021-11-25 10:56 ` [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Sandeep Maheswaram
@ 2021-11-25 10:56 ` Sandeep Maheswaram
  2021-12-01  3:28   ` Bjorn Andersson
  1 sibling, 1 reply; 6+ messages in thread
From: Sandeep Maheswaram @ 2021-11-25 10:56 UTC (permalink / raw)
  To: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, Matthias Kaehlcke
  Cc: devicetree, linux-arm-msm, linux-kernel, quic_pkondeti,
	quic_ppratap, Sandeep Maheswaram

Adding USB2 controller and phy nodes for SC7280 SKU1 board.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 9b991ba..ffd483d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -80,3 +80,19 @@
 		qcom,pre-scaling = <1 1>;
 	};
 };
+
+&usb_2 {
+	status = "okay";
+};
+
+&usb_2_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_2_hsphy {
+	status = "okay";
+
+	vdda-pll-supply = <&vreg_l10c_0p8>;
+	vdda33-supply = <&vreg_l2b_3p0>;
+	vdda18-supply = <&vreg_l1c_1p8>;
+};
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi
  2021-11-25 10:56 ` [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Sandeep Maheswaram
@ 2021-11-29 18:02   ` Matthias Kaehlcke
  2021-12-01  4:59     ` Sandeep Maheswaram
  0 siblings, 1 reply; 6+ messages in thread
From: Matthias Kaehlcke @ 2021-11-29 18:02 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, devicetree, linux-arm-msm, linux-kernel,
	quic_pkondeti, quic_ppratap

On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote:
> Remove USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>

A series shouldn't break things if it is only applied partially (in order). In
this case the USB2 controller wouldn't work on the SKU1 board if only this patch
is applied. It should be squashed with patch 2 of this series ("arm64: qcom:
sc7280: Add USB2 controller and phy nodes for SKU1 board").

Also doing the move in a single patch instead of two separate patches for remove
and add makes it easier to review the latter part, since it's evident from the
patch itself that it's just a move.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board
  2021-11-25 10:56 ` [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board Sandeep Maheswaram
@ 2021-12-01  3:28   ` Bjorn Andersson
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-12-01  3:28 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: Rob Herring, Andy Gross, Stephen Boyd, Doug Anderson,
	Matthias Kaehlcke, devicetree, linux-arm-msm, linux-kernel,
	quic_pkondeti, quic_ppratap

On Thu 25 Nov 04:56 CST 2021, Sandeep Maheswaram wrote:

> Adding USB2 controller and phy nodes for SC7280 SKU1 board.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 9b991ba..ffd483d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -80,3 +80,19 @@
>  		qcom,pre-scaling = <1 1>;
>  	};
>  };
> +
> +&usb_2 {
> +	status = "okay";
> +};
> +
> +&usb_2_dwc3 {
> +	dr_mode = "host";

The commit messages doesn't capture why the mode changes from peripheral
to host.

> +};
> +
> +&usb_2_hsphy {

Is this specific to this SKU? Is there a reason not to keep this in the
dtsi?


Please squash the two patches and please write a proper commit message.

Thanks,
Bjorn

> +	status = "okay";
> +
> +	vdda-pll-supply = <&vreg_l10c_0p8>;
> +	vdda33-supply = <&vreg_l2b_3p0>;
> +	vdda18-supply = <&vreg_l1c_1p8>;
> +};
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi
  2021-11-29 18:02   ` Matthias Kaehlcke
@ 2021-12-01  4:59     ` Sandeep Maheswaram
  0 siblings, 0 replies; 6+ messages in thread
From: Sandeep Maheswaram @ 2021-12-01  4:59 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, devicetree, linux-arm-msm, linux-kernel,
	quic_pkondeti, quic_ppratap


On 11/29/2021 11:32 PM, Matthias Kaehlcke wrote:
> On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote:
>> Remove USB2 controller and phy nodes from common dtsi file as it is
>> required only for SKU1 board.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> A series shouldn't break things if it is only applied partially (in order). In
> this case the USB2 controller wouldn't work on the SKU1 board if only this patch
> is applied. It should be squashed with patch 2 of this series ("arm64: qcom:
> sc7280: Add USB2 controller and phy nodes for SKU1 board").
>
> Also doing the move in a single patch instead of two separate patches for remove
> and add makes it easier to review the latter part, since it's evident from the
> patch itself that it's just a move.
Ok. Will do in next version.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-01  4:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 10:56 [PATCH 0/2] Remove USB2 nodes from SC7280 IDP common dtsi file Sandeep Maheswaram
2021-11-25 10:56 ` [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Sandeep Maheswaram
2021-11-29 18:02   ` Matthias Kaehlcke
2021-12-01  4:59     ` Sandeep Maheswaram
2021-11-25 10:56 ` [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board Sandeep Maheswaram
2021-12-01  3:28   ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).