LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk
@ 2021-11-26 11:33 Fabrice Gasnier
  2021-11-29 13:13 ` Alexandre TORGUE
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2021-11-26 11:33 UTC (permalink / raw)
  To: alexandre.torgue
  Cc: robh+dt, amelie.delaunay, linux-arm-kernel, devicetree,
	linux-kernel, linux-stm32, fabrice.gasnier, fabien.dessenne

A pinctrl handle is used to setup a pull-up on the stusb1600 IRQ pin (that
is open drain).
When in ANALOG state, no pull-up can be applied in the GPIO HW controller,
still the setting is done into the register. The pull-up is effective
currently, only when the GPIO IRQ is requested. The correct setting is to
use directly the GPIO, instead of ANALOG state.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 5f060fe..3b65130 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1718,7 +1718,7 @@
 
 	stusb1600_pins_a: stusb1600-0 {
 		pins {
-			pinmux = <STM32_PINMUX('I', 11, ANALOG)>;
+			pinmux = <STM32_PINMUX('I', 11, GPIO)>;
 			bias-pull-up;
 		};
 	};
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk
  2021-11-26 11:33 [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk Fabrice Gasnier
@ 2021-11-29 13:13 ` Alexandre TORGUE
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre TORGUE @ 2021-11-29 13:13 UTC (permalink / raw)
  To: Fabrice Gasnier
  Cc: robh+dt, amelie.delaunay, linux-arm-kernel, devicetree,
	linux-kernel, linux-stm32, fabien.dessenne

Hi Fabrice

On 11/26/21 12:33 PM, Fabrice Gasnier wrote:
> A pinctrl handle is used to setup a pull-up on the stusb1600 IRQ pin (that
> is open drain).
> When in ANALOG state, no pull-up can be applied in the GPIO HW controller,
> still the setting is done into the register. The pull-up is effective
> currently, only when the GPIO IRQ is requested. The correct setting is to
> use directly the GPIO, instead of ANALOG state.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 5f060fe..3b65130 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1718,7 +1718,7 @@
>   
>   	stusb1600_pins_a: stusb1600-0 {
>   		pins {
> -			pinmux = <STM32_PINMUX('I', 11, ANALOG)>;
> +			pinmux = <STM32_PINMUX('I', 11, GPIO)>;
>   			bias-pull-up;
>   		};
>   	};
> 

Applied on stm32-next

Regards
Alex

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-29 13:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 11:33 [PATCH] ARM: dts: stm32: fix stusb1600 pinctrl used on stm32mp157c-dk Fabrice Gasnier
2021-11-29 13:13 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).