LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Herring <robh@kernel.org>
Cc: linux-fbdev@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Hans de Goede <hdegoede@redhat.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: add missing simple-framebuffer formats
Date: Wed, 01 Sep 2021 21:29:18 +0200	[thread overview]
Message-ID: <1648705.hQpMTjSAMY@g550jk> (raw)
In-Reply-To: <YS6fZ4nFgic1DYhR@robh.at.kernel.org>

Hi Rob,

On Dienstag, 31. August 2021 23:30:15 CEST Rob Herring wrote:
> On Sat, Aug 28, 2021 at 01:02:05PM +0200, Luca Weiss wrote:
> > Document all formats currently present in include/linux/platform_data/
> > simplefb.h
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > 
> >  .../bindings/display/simple-framebuffer.yaml         | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
> > b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml index
> > c2499a7906f5..c1acd2859ae8 100644
> > --- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
> > +++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
> > 
> > @@ -83,13 +83,25 @@ properties:
> >    format:
> >      description: >
> >      
> >        Format of the framebuffer:
> > +        * `a1r5g5b5` - 16-bit pixels, d[15]=a, d[14:10]=r, d[9:5]=g,
> > d[4:0]=b +        * `a2r10g10b10` - 32-bit pixels, d[31:30]=a,
> > d[29:20]=r, d[19:10]=g, d[9:0]=b
> Not a new problem, but are these 32-bit big or little endian words? That
> should be figured out before we add more.

As I'm neither involved in the driver nor really have any knowledge on pixel 
formats, maybe the maintainers of the binding can help out here?
(Bartlomiej Zolnierkiewicz & Hans de Goede, both are CC'ed)

I can probably dig through the sources and guess but documentation should be 
written without guessing :)

Regards
Luca





      reply	other threads:[~2021-09-01 19:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 11:02 Luca Weiss
2021-08-31 21:30 ` Rob Herring
2021-09-01 19:29   ` Luca Weiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1648705.hQpMTjSAMY@g550jk \
    --to=luca@z3ntu.xyz \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    --subject='Re: [PATCH] dt-bindings: display: add missing simple-framebuffer formats' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).