LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [RFC 09/13] arm64: dts: allwinner: a64: Add HDMI support
Date: Tue, 24 Apr 2018 17:27:36 +0200	[thread overview]
Message-ID: <16951864.vHPjqCA7g4@jernej-laptop> (raw)
In-Reply-To: <20180424133425.24291-10-jagan@amarulasolutions.com>

Hi,

Dne torek, 24. april 2018 ob 15:34:21 CEST je Jagan Teki napisal(a):
> HDMI on Allwinner A64 has similar behavior like H3/H5, so
> reuse the same dts node details for A64.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 28
> +++++++++++++++++++++++++++ include/dt-bindings/clock/sun50i-a64-ccu.h    |
>  2 ++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> b8734319dc77..aa73f1ce1ab2 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -705,6 +705,34 @@
>  			#interrupt-cells = <3>;
>  		};
> 
> +		hdmi: hdmi@1ee0000 {
> +			compatible = "allwinner,sun50i-a64-dw-hdmi",
> +				     "allwinner,sun8i-a83t-dw-hdmi";
> +			reg = <0x01ee0000 0x10000>;
> +			reg-io-width = <1>;
> +			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&ccu CLK_BUS_HDMI>, <&ccu CLK_HDMI_DDC>,
> +				 <&ccu CLK_HDMI>;
> +			clock-names = "iahb", "isfr", "tmds";
> +			resets = <&ccu RST_BUS_HDMI1>;
> +			reset-names = "ctrl";
> +			phys = <&hdmi_phy>;
> +			phy-names = "hdmi-phy";
> +			status = "disabled";
> +		};
> +
> +		hdmi_phy: hdmi-phy@1ef0000 {
> +			compatible = "allwinner,sun50i-a64-hdmi-phy",
> +				     "allwinner,sun8i-h3-hdmi-phy";
> +			reg = <0x01ef0000 0x10000>;
> +			clocks = <&ccu CLK_BUS_HDMI>, <&ccu CLK_HDMI_DDC>,
> +				 <&ccu CLK_PLL_VIDEO0>;
> +			clock-names = "bus", "mod", "pll-0";

Unfortunately, that won't work in all cases. HDMI has two possible clock 
parents and only one can be selected. If HDMI controller clock has PLL_VIDEO1 
as a source, you will calculate wrong divider in HDMI PHY, since you will base 
calculations on PLL_VIDEO0. I think driver needs an expansion.

That is also one of the reasons why I didn't yet send A64 HDMI patch series (I 
didn't figure out this part yet). The other reason is that I'm waiting on SRAM 
C claiming code.

Best regards,
Jernej

> +			resets = <&ccu RST_BUS_HDMI0>;
> +			reset-names = "phy";
> +			#phy-cells = <0>;
> +		};
> +
>  		rtc: rtc@1f00000 {
>  			compatible = "allwinner,sun6i-a31-rtc";
>  			reg = <0x01f00000 0x54>;
> diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h
> b/include/dt-bindings/clock/sun50i-a64-ccu.h index
> d66432c6e675..a054ff665d6e 100644
> --- a/include/dt-bindings/clock/sun50i-a64-ccu.h
> +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h
> @@ -43,6 +43,8 @@
>  #ifndef _DT_BINDINGS_CLK_SUN50I_A64_H_
>  #define _DT_BINDINGS_CLK_SUN50I_A64_H_
> 
> +#define CLK_PLL_VIDEO0		7
> +
>  #define CLK_PLL_PERIPH0		11
> 
>  #define CLK_BUS_MIPI_DSI	28
> --
> 2.14.3

  reply	other threads:[~2018-04-24 15:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:34 [RFC 00/13] arm64: allwinner: Add A64 DE2 pipeline support Jagan Teki
2018-04-24 13:34 ` [RFC 01/13] dt-bindings: clock: Add compatible for A64 DE2 CCU Jagan Teki
2018-04-24 13:34 ` [RFC 02/13] arm64: dts: allwinner: a64: Add " Jagan Teki
2018-04-24 13:34 ` [RFC 03/13] bindings: display: Add compatible for A64 DE2 pipeline Jagan Teki
2018-04-24 13:37   ` Chen-Yu Tsai
2018-04-24 13:34 ` [RFC 04/13] bindings: display: Add compatible for A64 Mixer0 Jagan Teki
2018-04-24 13:34 ` [RFC 05/13] bindings: display: Add compatible for A64 tcon-lcd Jagan Teki
2018-04-24 13:34 ` [RFC 06/13] arm64: dts: allwinner: a64: Add DE2 pipeline Jagan Teki
2018-04-24 13:34 ` [RFC 07/13] bindings: display: Add compatible for A64 HDMI Jagan Teki
2018-04-24 13:34 ` [RFC 08/13] bindings: display: Add compatible for A64 HDMI PHY Jagan Teki
2018-04-24 13:34 ` [RFC 09/13] arm64: dts: allwinner: a64: Add HDMI support Jagan Teki
2018-04-24 15:27   ` Jernej Škrabec [this message]
2018-04-24 13:34 ` [RFC 10/13] bindings: display: Add compatible for A64 Mixer1 Jagan Teki
2018-04-24 13:34 ` [RFC 11/13] bindings: display: Add compatible for A64 tcon-tv Jagan Teki
2018-04-24 13:34 ` [RFC 12/13] arm64: dts: allwinner: a64: Add HDMI pipeline Jagan Teki
2018-04-24 13:34 ` [RFC 13/13] arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output Jagan Teki
2018-04-24 14:08 ` [RFC 00/13] arm64: allwinner: Add A64 DE2 pipeline support Maxime Ripard
2018-04-25 12:59   ` Jagan Teki
2018-04-25 13:55     ` Maxime Ripard
2018-04-25 18:06       ` Jernej Škrabec
2018-04-24 15:32 ` Jernej Škrabec
2018-04-25 10:34   ` Jagan Teki
2018-04-25 17:59     ` Jernej Škrabec
2018-04-26 13:26       ` Jagan Teki
2018-04-26 22:13         ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16951864.vHPjqCA7g4@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=michael@amarulasolutions.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    --subject='Re: [RFC 09/13] arm64: dts: allwinner: a64: Add HDMI support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).