LKML Archive on
help / color / mirror / Atom feed
From: Jens Axboe <>
To: Randy Dunlap <>,
	Jiang Biao <>
Subject: Re: [PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue
Date: Thu, 19 Apr 2018 11:23:39 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 4/19/18 11:10 AM, Randy Dunlap wrote:
> On 04/19/18 07:52, Jens Axboe wrote:
>> On 4/18/18 10:04 PM, Jiang Biao wrote:
>>> The comment before blkg_create() in blkcg_init_queue() was moved
>>> from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but
>>> it does not suit for the new context.
>> Applied - btw, in the future, if you send more than one patch in
>> a series, please include a cover letter.
> Hi Jens,
> Where does that cover letter requirement come from?  It's not documented
> anywhere AFAICT and shouldn't be needed for such small patch series.

It's not a requirement, I just strongly prefer it for anything that is
more than one patch. Hence I tend to let people know about that
preference, if they send patches more than once.

It makes it possible to send comments for the series as a whole.

Jens Axboe

      reply	other threads:[~2018-04-19 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  4:04 Jiang Biao
2018-04-19 14:52 ` Jens Axboe
2018-04-19 17:10   ` Randy Dunlap
2018-04-19 17:23     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).