LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static
@ 2018-06-01 13:05 Colin King
  2018-06-04  7:11 ` Viresh Kumar
  0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-06-01 13:05 UTC (permalink / raw)
  To: Rafael J . Wysocki, Viresh Kumar, linux-pm; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The function acpi_cpufreq_fast_switch is local to the source and does
not need to be in global scope, so make it static.

Cleans up sparse warning:
drivers/cpufreq/acpi-cpufreq.c:468:14: warning: symbol
'acpi_cpufreq_fast_switch' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/cpufreq/acpi-cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index 9449657d72f0..32ba4bc972e7 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -465,8 +465,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
 	return result;
 }
 
-unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
-				      unsigned int target_freq)
+static unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
+					     unsigned int target_freq)
 {
 	struct acpi_cpufreq_data *data = policy->driver_data;
 	struct acpi_processor_performance *perf;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static
  2018-06-01 13:05 [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static Colin King
@ 2018-06-04  7:11 ` Viresh Kumar
  2018-06-12 15:00   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-06-04  7:11 UTC (permalink / raw)
  To: Colin King; +Cc: Rafael J . Wysocki, linux-pm, kernel-janitors, linux-kernel

On 01-06-18, 14:05, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function acpi_cpufreq_fast_switch is local to the source and does
> not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/cpufreq/acpi-cpufreq.c:468:14: warning: symbol
> 'acpi_cpufreq_fast_switch' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 9449657d72f0..32ba4bc972e7 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -465,8 +465,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
>  	return result;
>  }
>  
> -unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> -				      unsigned int target_freq)
> +static unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> +					     unsigned int target_freq)
>  {
>  	struct acpi_cpufreq_data *data = policy->driver_data;
>  	struct acpi_processor_performance *perf;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static
  2018-06-04  7:11 ` Viresh Kumar
@ 2018-06-12 15:00   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-06-12 15:00 UTC (permalink / raw)
  To: Viresh Kumar, Colin King; +Cc: linux-pm, kernel-janitors, linux-kernel

On Monday, June 4, 2018 9:11:41 AM CEST Viresh Kumar wrote:
> On 01-06-18, 14:05, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The function acpi_cpufreq_fast_switch is local to the source and does
> > not need to be in global scope, so make it static.
> > 
> > Cleans up sparse warning:
> > drivers/cpufreq/acpi-cpufreq.c:468:14: warning: symbol
> > 'acpi_cpufreq_fast_switch' was not declared. Should it be static?
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/cpufreq/acpi-cpufreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index 9449657d72f0..32ba4bc972e7 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -465,8 +465,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
> >  	return result;
> >  }
> >  
> > -unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > -				      unsigned int target_freq)
> > +static unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > +					     unsigned int target_freq)
> >  {
> >  	struct acpi_cpufreq_data *data = policy->driver_data;
> >  	struct acpi_processor_performance *perf;
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> 

Patch applied, thanks!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-12 15:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 13:05 [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static Colin King
2018-06-04  7:11 ` Viresh Kumar
2018-06-12 15:00   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).