LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Snitzer" <snitzer@gmail.com>
To: "Paul Clements" <paul.clements@steeleye.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Randy Dunlap" <randy.dunlap@oracle.com>,
	nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	"Jens Axboe" <jens.axboe@oracle.com>
Subject: Re: [Nbd] [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler
Date: Fri, 8 Feb 2008 17:45:11 -0500	[thread overview]
Message-ID: <170fa0d20802081445i42ff7f9em919946d0dc0537b0@mail.gmail.com> (raw)
In-Reply-To: <47ACA250.1010404@steeleye.com>

On Feb 8, 2008 1:41 PM, Paul Clements <paul.clements@steeleye.com> wrote:
> Andrew Morton wrote:
> > On Fri, 8 Feb 2008 09:33:41 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >
> >> On Fri, 08 Feb 2008 11:47:42 -0500 Paul Clements wrote:
> >>
> >>> There have been numerous reports of problems with nbd and cfq. Deadline
> >>> gives better performance for nbd, anyway, so let's use it by default.
> >
> > Please define "problems".  If it's just "slowness" then we can live with
> > that, but I'd hope that Jens is aware and that it's understood.
> >
> > It it's "hangs" or "oopses" then we panic.
>
> The two problems I have experienced (which may already be fixed):
>
> 1) nbd hangs with cfq on RHEL 5 (2.6.18) -- this may well have been fixed

It has been fixed in RHEL5 (but not yet released AFAIK):
https://bugzilla.redhat.com/show_bug.cgi?id=241540#c43

On a slightly related performance note; I'm seeing that for NBD
devices both max_hw_sectors_kb  and max_sectors_kb are 127.  If I set
it to be 256 with the following patch I see a 25% improvement in
overall throughput:

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5def9c5..ed63e2f 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -764,6 +764,7 @@ static int __init nbd_init(void)
                        put_disk(disk);
                        goto out;
                }
+               blk_queue_max_sectors(disk->queue, 512);
        }

        if (register_blkdev(NBD_MAJOR, "nbd")) {

Any chance we can take steps to make NBD not be artificially slow?
Any other recommendations for improving NBD throughput?

regards,
Mike

      parent reply	other threads:[~2008-02-08 22:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 16:47 Paul Clements
2008-02-08 17:33 ` Randy Dunlap
2008-02-08 18:11   ` Andrew Morton
2008-02-08 18:41     ` Paul Clements
2008-02-08 20:45       ` Jens Axboe
2008-02-08 20:47         ` Jens Axboe
2008-02-08 21:23           ` Paul Clements
2008-02-08 22:02             ` Andrew Morton
2008-02-09 13:30               ` Paul Clements
2008-02-12 23:16                 ` Andrew Morton
2008-02-18 18:16                   ` Jens Axboe
2008-02-18 23:50                     ` Andrew Morton
2008-02-19  9:19                       ` Jens Axboe
2008-02-19  9:24                         ` Jens Axboe
2008-02-19 10:02                           ` Andrew Morton
2008-02-19 10:05                             ` Jens Axboe
2008-02-08 22:45       ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170fa0d20802081445i42ff7f9em919946d0dc0537b0@mail.gmail.com \
    --to=snitzer@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd-general@lists.sourceforge.net \
    --cc=paul.clements@steeleye.com \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [Nbd] [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).