LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paolo Valente <paolo.valente@linaro.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block <linux-block@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	linus.walleij@linaro.org, bfq-iosched@googlegroups.com,
	oleksandr@natalenko.name
Subject: Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge
Date: Mon, 7 May 2018 11:27:25 +0200	[thread overview]
Message-ID: <1723D46D-579A-4C5A-BCC1-6ABAA6E7C3FB@linaro.org> (raw)
In-Reply-To: <1525672597.5064.3.camel@gmx.de>



> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith <efault@gmx.de> ha scritto:
> 
> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote:
>> 
>> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c
>> index 118f319af7c0..6662efe29b69 100644
>> --- a/block/bfq-mq-iosched.c
>> +++ b/block/bfq-mq-iosched.c
>> @@ -525,8 +525,13 @@ static void bfq_limit_depth(unsigned int op, struct blk_mq_alloc_data *data)
>>        if (unlikely(bfqd->sb_shift != bt->sb.shift))
>>                bfq_update_depths(bfqd, bt);
>> 
>> +#if 0
>>        data->shallow_depth =
>>                bfqd->word_depths[!!bfqd->wr_busy_queues][op_is_sync(op)];
>                                                            ^^^^^^^^^^^^^
> 
> Q: why doesn't the top of this function look like so?
> 
> ---
> block/bfq-iosched.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -539,7 +539,7 @@ static void bfq_limit_depth(unsigned int
> 	struct bfq_data *bfqd = data->q->elevator->elevator_data;
> 	struct sbitmap_queue *bt;
> 
> -	if (op_is_sync(op) && !op_is_write(op))
> +	if (!op_is_write(op))
> 		return;
> 
> 	if (data->flags & BLK_MQ_REQ_RESERVED) {
> 
> It looks a bit odd that these elements exist...
> 
> +       /*
> +        * no more than 75% of tags for sync writes (25% extra tags
> +        * w.r.t. async I/O, to prevent async I/O from starving sync
> +        * writes)
> +        */
> +       bfqd->word_depths[0][1] = max(((1U<<bfqd->sb_shift) * 3)>>2, 1U);
> 
> +       /* no more than ~37% of tags for sync writes (~20% extra tags) */
> +       bfqd->word_depths[1][1] = max(((1U<<bfqd->sb_shift) * 6)>>4, 1U);
> 
> ...yet we index via and log a guaranteed zero.
> 

I'm not sure I got your point, so, to help you help me quickly, I'll
repeat what I expect the code you highlight to do:

- sync reads must have no limitation, and the lines
if (op_is_sync(op) && !op_is_write(op))
	return;
make sure they don't

- sync writes must be limited, and the code you pasted above computes
those limits

- for sync writes, for which op_is_sync(op) is true (but the condition
"op_is_sync(op) && !op_is_write(op)" is false), the line:
	bfqd->word_depths[!!bfqd->wr_busy_queues][op_is_sync(op)];
becomes
	bfqd->word_depths[!!bfqd->wr_busy_queues][1];
e yields the right limit for sync writes, depending on bfqd->wr_busy_queues.

Where is the bug?

Thanks,
Paolo


> 	-Mike
> 
> 

  reply	other threads:[~2018-05-07  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 17:17 Paolo Valente
2018-05-04 19:46 ` Mike Galbraith
2018-05-05  8:19   ` Mike Galbraith
2018-05-05 10:39     ` Paolo Valente
2018-05-05 14:56       ` Mike Galbraith
2018-05-06  7:42         ` Paolo Valente
2018-05-07  2:43           ` Mike Galbraith
2018-05-07  3:23             ` Mike Galbraith
2018-05-07  9:32               ` Paolo Valente
2018-05-07  5:56           ` Mike Galbraith
2018-05-07  9:27             ` Paolo Valente [this message]
2018-05-07 10:01               ` Mike Galbraith
2018-05-07 18:03                 ` Paolo Valente
2018-05-06  7:33 ` Oleksandr Natalenko
2018-05-10 16:14 ` Bart Van Assche
2018-05-14 17:16   ` Paolo Valente
2018-05-14 17:31     ` Jens Axboe
2018-05-14 17:37       ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1723D46D-579A-4C5A-BCC1-6ABAA6E7C3FB@linaro.org \
    --to=paolo.valente@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=bfq-iosched@googlegroups.com \
    --cc=broonie@kernel.org \
    --cc=efault@gmx.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).