LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kevin Hilman <khilman@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linaro Networking <linaro-networking@linaro.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] clockevents: Introduce mode specific callbacks
Date: Fri, 13 Feb 2015 15:46:11 +0100 [thread overview]
Message-ID: <1757256.KD83W4bJsz@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpokKP_-SMB6LX1O82w5YC5mkMgswF=Fy6e9E=u9iQkr=OQ@mail.gmail.com>
On Friday, February 13, 2015 11:01:18 AM Viresh Kumar wrote:
> On 13 February 2015 at 10:11, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, February 13, 2015 08:54:56 AM Viresh Kumar wrote:
> >> It is not possible for the clockevents core to know which modes (other than
> >> those with a corresponding feature flag) are supported by a particular
> >> implementation. And drivers are expected to handle transition to all modes
> >> elegantly, as ->set_mode() would be issued for them unconditionally.
> >>
> >> Now, adding support for a new mode complicates things a bit if we want to use
> >> the legacy ->set_mode() callback. We need to closely review all clockevents
> >> drivers to see if they would break on addition of a new mode. And after such
> >> reviews, it is found that we have to do non-trivial changes to most of the
> >> drivers [1].
> >>
> >> Introduce mode-specific set_mode_*() callbacks, some of which the drivers may or
> >> may not implement. A missing callback would clearly convey the message that the
> >> corresponding mode isn't supported.
> >
> > This is not going to fly AFAICS if you don't say what exacly you need it for.
>
> For this: https://lkml.org/lkml/2014/5/9/508
OK, I see.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-02-13 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 0:54 Viresh Kumar
2015-02-13 2:11 ` Rafael J. Wysocki
2015-02-13 3:01 ` Viresh Kumar
2015-02-13 14:46 ` Rafael J. Wysocki [this message]
2015-02-13 3:42 ` Preeti U Murthy
2015-02-18 17:09 ` [tip:timers/core] " tip-bot for Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1757256.KD83W4bJsz@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--subject='Re: [PATCH v2] clockevents: Introduce mode specific callbacks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).