LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clk: rockchip: use module_platform_driver_probe
@ 2021-09-02 7:57 Miles Chen
2021-09-03 18:32 ` Stephen Boyd
2021-09-03 20:59 ` Heiko Stübner
0 siblings, 2 replies; 5+ messages in thread
From: Miles Chen @ 2021-09-02 7:57 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Heiko Stuebner
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-mediatek, wsd_upstream, Miles Chen
Replace builtin_platform_driver_probe with module_platform_driver_probe
because that rk3399 and rk3568 can be built as kernel modules.
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
drivers/clk/rockchip/clk-rk3399.c | 2 +-
drivers/clk/rockchip/clk-rk3568.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
index 62a4f2543960..a5169156f1d2 100644
--- a/drivers/clk/rockchip/clk-rk3399.c
+++ b/drivers/clk/rockchip/clk-rk3399.c
@@ -1653,7 +1653,7 @@ static struct platform_driver clk_rk3399_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
+module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index 75ca855e720d..939e7079c334 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1719,7 +1719,7 @@ static struct platform_driver clk_rk3568_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
+module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
MODULE_LICENSE("GPL");
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: rockchip: use module_platform_driver_probe
2021-09-02 7:57 [PATCH] clk: rockchip: use module_platform_driver_probe Miles Chen
@ 2021-09-03 18:32 ` Stephen Boyd
2021-09-04 14:59 ` Miles Chen
2021-09-03 20:59 ` Heiko Stübner
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2021-09-03 18:32 UTC (permalink / raw)
To: Heiko Stuebner, Michael Turquette, Miles Chen
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-mediatek, wsd_upstream, Miles Chen
Quoting Miles Chen (2021-09-02 00:57:13)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Should it have a fixes tag?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: rockchip: use module_platform_driver_probe
2021-09-02 7:57 [PATCH] clk: rockchip: use module_platform_driver_probe Miles Chen
2021-09-03 18:32 ` Stephen Boyd
@ 2021-09-03 20:59 ` Heiko Stübner
2021-09-04 15:00 ` Miles Chen
1 sibling, 1 reply; 5+ messages in thread
From: Heiko Stübner @ 2021-09-03 20:59 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Miles Chen
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-mediatek, wsd_upstream, Miles Chen
Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
on both rk3399 and rk3568:
Tested-by: Heiko Stuebner <heiko@sntech.de>
and also
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
> ---
> drivers/clk/rockchip/clk-rk3399.c | 2 +-
> drivers/clk/rockchip/clk-rk3568.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 62a4f2543960..a5169156f1d2 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -1653,7 +1653,7 @@ static struct platform_driver clk_rk3399_driver = {
> .suppress_bind_attrs = true,
> },
> };
> -builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
>
> MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
> index 75ca855e720d..939e7079c334 100644
> --- a/drivers/clk/rockchip/clk-rk3568.c
> +++ b/drivers/clk/rockchip/clk-rk3568.c
> @@ -1719,7 +1719,7 @@ static struct platform_driver clk_rk3568_driver = {
> .suppress_bind_attrs = true,
> },
> };
> -builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
>
> MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: rockchip: use module_platform_driver_probe
2021-09-03 18:32 ` Stephen Boyd
@ 2021-09-04 14:59 ` Miles Chen
0 siblings, 0 replies; 5+ messages in thread
From: Miles Chen @ 2021-09-04 14:59 UTC (permalink / raw)
To: Stephen Boyd, Heiko Stuebner, Michael Turquette
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-mediatek, wsd_upstream
On Fri, 2021-09-03 at 11:32 -0700, Stephen Boyd wrote:
> Quoting Miles Chen (2021-09-02 00:57:13)
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> >
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Signed-off-by: Miles Chen <miles.chen@mediatek.com>
>
> Should it have a fixes tag?
ok, I will add a fixes tags in the next patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: rockchip: use module_platform_driver_probe
2021-09-03 20:59 ` Heiko Stübner
@ 2021-09-04 15:00 ` Miles Chen
0 siblings, 0 replies; 5+ messages in thread
From: Miles Chen @ 2021-09-04 15:00 UTC (permalink / raw)
To: Heiko Stübner, Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-mediatek, wsd_upstream
On Fri, 2021-09-03 at 22:59 +0200, Heiko Stübner wrote:
> Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> >
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Signed-off-by: Miles Chen <miles.chen@mediatek.com>
>
> on both rk3399 and rk3568:
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> and also
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
thanks for doing the test. I will add your tags in my next patch.
>
> Heiko
>
> > ---
> > drivers/clk/rockchip/clk-rk3399.c | 2 +-
> > drivers/clk/rockchip/clk-rk3568.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/rockchip/clk-rk3399.c
> > b/drivers/clk/rockchip/clk-rk3399.c
> > index 62a4f2543960..a5169156f1d2 100644
> > --- a/drivers/clk/rockchip/clk-rk3399.c
> > +++ b/drivers/clk/rockchip/clk-rk3399.c
> > @@ -1653,7 +1653,7 @@ static struct platform_driver
> > clk_rk3399_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3399_driver,
> > clk_rk3399_probe);
> > +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/clk/rockchip/clk-rk3568.c
> > b/drivers/clk/rockchip/clk-rk3568.c
> > index 75ca855e720d..939e7079c334 100644
> > --- a/drivers/clk/rockchip/clk-rk3568.c
> > +++ b/drivers/clk/rockchip/clk-rk3568.c
> > @@ -1719,7 +1719,7 @@ static struct platform_driver
> > clk_rk3568_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3568_driver,
> > clk_rk3568_probe);
> > +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> > MODULE_LICENSE("GPL");
> >
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-04 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 7:57 [PATCH] clk: rockchip: use module_platform_driver_probe Miles Chen
2021-09-03 18:32 ` Stephen Boyd
2021-09-04 14:59 ` Miles Chen
2021-09-03 20:59 ` Heiko Stübner
2021-09-04 15:00 ` Miles Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).