LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Missing include in include/asm-powerpc/prom.h
Date: Tue, 6 Feb 2007 11:36:04 +1100	[thread overview]
Message-ID: <17863.52596.791276.129355@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070205205636.GA14589@Krystal>

Mathieu Desnoyers writes:

> * Benjamin Herrenschmidt (benh@kernel.crashing.org) wrote:
> > On Mon, 2007-02-05 at 09:29 -0500, Mathieu Desnoyers wrote:
> > > Missing include in include/asm-powerpc/prom.h
> > > 
> > > include/asm-powerpc/prom.h needs to include asm/irq.h because it uses
> > > irq_of_parse_and_map and NO_IRQ. It applies on 2.6.20.
> > 
> > I'd rather not do that.... better to move of_irq_to_resource() to
> > prom_parse.c 
> > 
> 
> Thanks, this patch should apply on top of the previous patch in this thread.

Do you actually want this patch to go upstream?  Because if you do,
that really doesn't cut it as a patch description.  Please look at
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt and resubmit
as one patch with an informative description.

Thanks,
Paul.

  reply	other threads:[~2007-02-06  0:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 14:29 Mathieu Desnoyers
2007-02-05 20:14 ` Benjamin Herrenschmidt
2007-02-05 20:56   ` Mathieu Desnoyers
2007-02-06  0:36     ` Paul Mackerras [this message]
2007-02-06  1:03       ` [PATCH] Powerpc move of_irq_to_resource from prom.h to prom_parse.c Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17863.52596.791276.129355@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --subject='Re: [PATCH] Missing include in include/asm-powerpc/prom.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).