LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kai" <epimetreus@fastmail.fm>,
	stable@suse.de, org@suse.de, linux-kernel@vger.kernel.org,
	Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537!
Date: Wed, 7 Feb 2007 12:30:39 +1100	[thread overview]
Message-ID: <17865.11199.612391.738320@notabene.brown> (raw)
In-Reply-To: message from Andrew Morton on Tuesday February 6

On Tuesday February 6, akpm@linux-foundation.org wrote:
> On Wed, 7 Feb 2007 10:26:56 +1100
> Neil Brown <neilb@suse.de> wrote:
> 
> > +static int bio_fits_rdev(struct bio *bi)
> > +{
> > +	request_queue_t *q = bdev_get_queue(bi->bi_bdev);
> > +
> > +	if ((bi->bi_size>>9) > q->max_sectors)
> > +		return 0;
> > +	blk_recount_segments(q, bi);
> > +	if (bi->bi_phys_segments > q->max_phys_segments ||
> > +	    bi->bi_hw_segments > q->max_hw_segments)
> > +		return 0;
> > +
> > +	if (q->merge_bvec_fn)
> > +		/* it's too hard to apply the merge_bvec_fn at this stage,
> > +		 * just just give up
> > +		 */
> > +		return 0;
> > +
> > +	return 1;
> > +}
> 
> Isn't think going to return 0 rather a lot of the time?

Why do you say that?

merge_bvec_fn is only set for dm, md, pktcdvd.c so what won't cause a
zero in real-world cases (it rarely makes sense to put a raid5 on top
of those things).
So it will only return zero when ->max_sectors or ->max_*_segments are
less than the default, and while there are certainly quite a few of
those I wouldn't have expected them to be a majority (else we would
have had more complaints from -mm testers).

Yes, we should find the minimum of those values for devices currently
in the array and use that information in raid5's merge_bvec_fn to stop
bios growing too large.  That would make it return 0 somewhat less
often.
But I think for a lot of modern hardware, it won't return 0 at all....
or am I just not seeing some really obvious typo that you can see ??

NeilBrown


  reply	other threads:[~2007-02-07  1:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  4:08 Kai
2007-02-06  4:37 ` Andrew Morton
2007-02-06  5:24   ` Neil Brown
2007-02-06 23:26     ` [PATCH] " Neil Brown
2007-02-07  1:15       ` Andrew Morton
2007-02-07  1:30         ` Neil Brown [this message]
2007-02-07  1:40           ` Andrew Morton
2007-02-07 16:26       ` Kai
2007-02-07 22:08         ` Neil Brown
2007-02-09 17:15           ` Kai
2007-02-12  8:51       ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17865.11199.612391.738320@notabene.brown \
    --to=neilb@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=epimetreus@fastmail.fm \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=org@suse.de \
    --cc=stable@suse.de \
    --subject='Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).