LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Greg KH <greg@kroah.com>
Cc: Andreas Gruenbacher <agruen@suse.de>,
	torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
	hch@lst.de, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: Bug in current -git tree causing dbus and gnome to chew up cpu time
Date: Wed, 14 Feb 2007 09:39:10 +1100	[thread overview]
Message-ID: <17874.15886.523387.629797@notabene.brown> (raw)
In-Reply-To: message from Greg KH on Tuesday February 13

On Tuesday February 13, greg@kroah.com wrote:
> 
> This causes the following to just loop over and over, incrementing the
> pid:
> 
> gnome-vfs-daemo(8914): 

That's odd.  getcwd returning an empty string.
I can only see that happening if you do the equivalent of
   chdir("/");
   chroot("/somewhere");
   getcwd(buf,sizeof(buf));

That would return an empty string with the new code but not with the
old.
But I cannot imagine gnome-vfs-daemon doing a chroot, as it does not
run as root.

You could try removing the
		if (*buffer == '/') {
			buffer++;
			buflen++;
		}
from the new __d_path.  But that still wouldn't really explain what
was happening.

Maybe also put a WARN_ON(! *buffer) just before the return to find out
exactly what is going on when the empty string is returned.

NeilBrown

  parent reply	other threads:[~2007-02-13 22:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13 19:51 Greg KH
2007-02-13 19:58 ` Andreas Gruenbacher
     [not found]   ` <20070213200132.GA6149@kroah.com>
2007-02-13 20:16     ` Andreas Gruenbacher
2007-02-13 21:37   ` Greg KH
2007-02-13 22:30     ` Andreas Gruenbacher
2007-02-13 22:39     ` Neil Brown [this message]
2007-02-13 23:03       ` Andreas Gruenbacher
2007-02-14  9:47 ` Alessandro Suardi
2007-02-14  9:57   ` Andreas Gruenbacher
2007-02-14 11:13     ` Alessandro Suardi
2007-02-14 16:39       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17874.15886.523387.629797@notabene.brown \
    --to=neilb@suse.de \
    --cc=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: Bug in current -git tree causing dbus and gnome to chew up cpu time' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).