LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: liuqifa <liuqifa@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"dsahern@gmail.com" <dsahern@gmail.com>,
	"maheshb@google.com" <maheshb@google.com>,
	"weiyongjun (A)" <weiyongjun1@huawei.com>,
	maowenan <maowenan@huawei.com>,
	Dingtianhong <dingtianhong@huawei.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH] ipvlan: flush arp table when mac address changed
Date: Mon, 14 May 2018 08:49:07 +0000	[thread overview]
Message-ID: <17EB61BE5174F5429F67504099B599AFB9C395@DGGEMM501-MBX.china.huawei.com> (raw)
In-Reply-To: <1526283581.4411.2.camel@redhat.com>

Hi,
> 
> Hi,
> 
> On Sat, 2018-05-12 at 19:00 +0800, liuqifa@huawei.com wrote:
> > From: Keefe Liu <liuqifa@huawei.com>
> >
> > When master device's mac has been changed, the commit <32c10bbfe914>
> > "ipvlan: always use the current L2 addr of the master" makes the
> > IPVlan devices's mac changed also, but it doesn't flush the IPVlan's
> > arp table.
> >
> > Signed-off-by: Keefe Liu <liuqifa@huawei.com>
> > ---
> >  drivers/net/ipvlan/ipvlan_main.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ipvlan/ipvlan_main.c
> > b/drivers/net/ipvlan/ipvlan_main.c
> > index 450eec2..a1edfe1 100644
> > --- a/drivers/net/ipvlan/ipvlan_main.c
> > +++ b/drivers/net/ipvlan/ipvlan_main.c
> > @@ -7,6 +7,8 @@
> >   *
> >   */
> >
> > +#include <net/neighbour.h>
> > +#include <net/arp.h>
> >  #include "ipvlan.h"
> >
> >  static unsigned int ipvlan_netid __read_mostly; @@ -792,8 +794,10 @@
> > static int ipvlan_device_event(struct notifier_block *unused,
> >  		break;
> >
> >  	case NETDEV_CHANGEADDR:
> > -		list_for_each_entry(ipvlan, &port->ipvlans, pnode)
> > +		list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
> >  			ether_addr_copy(ipvlan->dev->dev_addr, dev-
> >dev_addr);
> > +			neigh_changeaddr(&arp_tbl, ipvlan->dev);
> > +		}
> 
> Why don't using:
> 
>  call_netdevice_notifiers(NETDEV_CHANGEADDR, ipvlan->dev);
> 
> instead?
> 
> that is what other stacked device - bridge and vlans - are currently doing in
> the same scenario.
> 
> Thanks,
> 
> Paolo
>
Yes, I agre with you, this is a better solution.

Thanks

Keefe

      reply	other threads:[~2018-05-14  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12 11:00 liuqifa
2018-05-14  7:39 ` Paolo Abeni
2018-05-14  8:49   ` liuqifa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17EB61BE5174F5429F67504099B599AFB9C395@DGGEMM501-MBX.china.huawei.com \
    --to=liuqifa@huawei.com \
    --cc=davem@davemloft.net \
    --cc=dingtianhong@huawei.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maheshb@google.com \
    --cc=maowenan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=weiyongjun1@huawei.com \
    --subject='Re: 答复: [PATCH] ipvlan: flush arp table when mac address changed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).