LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chengguang Xu <cgxu519@mykernel.net>
To: "Jan Kara" <jack@suse.cz>
Cc: "miklos" <miklos@szeredi.hu>, "amir73il" <amir73il@gmail.com>,
	"linux-unionfs" <linux-unionfs@vger.kernel.org>,
	"linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"Chengguang Xu" <charliecgxu@tencent.com>,
	"ronyjin" <ronyjin@tencent.com>
Subject: Re: [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper
Date: Fri, 26 Nov 2021 21:06:10 +0800	[thread overview]
Message-ID: <17d5c5a6fed.f090bcae10973.4735687401243313694@mykernel.net> (raw)
In-Reply-To: <20211126091007.GB13004@quack2.suse.cz>

 ---- 在 星期五, 2021-11-26 17:10:07 Jan Kara <jack@suse.cz> 撰写 ----
 > On Mon 22-11-21 11:00:33, Chengguang Xu wrote:
 > > From: Chengguang Xu <charliecgxu@tencent.com>
 > > 
 > > We simply mark overlayfs inode dirty when it has upper,
 > > it's much simpler than mark dirtiness on modification.
 > > 
 > > Signed-off-by: Chengguang Xu <charliecgxu@tencent.com>
 > > ---
 > >  fs/overlayfs/inode.c | 4 +++-
 > >  fs/overlayfs/util.c  | 1 +
 > >  2 files changed, 4 insertions(+), 1 deletion(-)
 > > 
 > > diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
 > > index 1f36158c7dbe..027ffc0a2539 100644
 > > --- a/fs/overlayfs/inode.c
 > > +++ b/fs/overlayfs/inode.c
 > > @@ -778,8 +778,10 @@ void ovl_inode_init(struct inode *inode, struct ovl_inode_params *oip,
 > >  {
 > >      struct inode *realinode;
 > >  
 > > -    if (oip->upperdentry)
 > > +    if (oip->upperdentry) {
 > >          OVL_I(inode)->__upperdentry = oip->upperdentry;
 > > +        mark_inode_dirty(inode);
 > > +    }
 > >      if (oip->lowerpath && oip->lowerpath->dentry)
 > >          OVL_I(inode)->lower = igrab(d_inode(oip->lowerpath->dentry));
 > >      if (oip->lowerdata)
 > 
 > Hum, does this get called only for inodes with upper inode existing? I
 > suppose we do not need to track inodes that were not copied up because they
 > cannot be dirty? I'm sorry, my knowledge of overlayfs is rather limited so
 > I may be missing something basic.
 > 

Well, as long as overly inode has upper it can be modified without copy-up,
so we need to track all overlay inodes which have upper inode.

Thanks,
Chengguang



  reply	other threads:[~2021-11-26 13:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  3:00 [RFC PATCH V6 0/7] implement containerized syncfs for overlayfs Chengguang Xu
2021-11-22  3:00 ` [RFC PATCH V6 1/7] ovl: setup overlayfs' private bdi Chengguang Xu
2021-11-26  8:51   ` Jan Kara
2021-11-22  3:00 ` [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper Chengguang Xu
2021-11-26  9:10   ` Jan Kara
2021-11-26 13:06     ` Chengguang Xu [this message]
2021-11-26 14:32       ` Jan Kara
2021-11-22  3:00 ` [RFC PATCH V6 3/7] ovl: implement overlayfs' own ->write_inode operation Chengguang Xu
2021-11-26  9:14   ` Jan Kara
2021-11-26 13:09     ` Chengguang Xu
2021-11-22  3:00 ` [RFC PATCH V6 4/7] ovl: set 'DONTCACHE' flag for overlayfs inode Chengguang Xu
2021-11-26  9:20   ` Jan Kara
2021-11-22  3:00 ` [RFC PATCH V6 5/7] fs: export wait_sb_inodes() Chengguang Xu
2021-11-26  9:20   ` Jan Kara
2021-11-22  3:00 ` [RFC PATCH V6 6/7] ovl: introduce ovl_sync_upper_blockdev() Chengguang Xu
2021-11-26  9:21   ` Jan Kara
2021-11-22  3:00 ` [RFC PATCH V6 7/7] ovl: implement containerized syncfs for overlayfs Chengguang Xu
2021-11-22  7:40   ` Amir Goldstein
2021-11-26  5:03     ` Chengguang Xu
2021-11-26  9:25   ` Jan Kara
2021-11-27  9:26 ` 回复:[RFC PATCH V6 0/7] " Chengguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17d5c5a6fed.f090bcae10973.4735687401243313694@mykernel.net \
    --to=cgxu519@mykernel.net \
    --cc=amir73il@gmail.com \
    --cc=charliecgxu@tencent.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=ronyjin@tencent.com \
    --subject='Re: [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).