LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: trimarchi@feanor.sssup.it
To: "David Brownell" <david-b@pacbell.net>
Cc: "Haavard Skinnemoen" <hskinnemoen@atmel.com>,
	"michael" <trimarchi@gandalf.sssup.it>,
	linux-kernel@vger.kernel.org,
	"Andrew Victor" <linux@maxim.org.za>
Subject: Re: at91sam9260 wakeup on serial port
Date: Mon, 28 Jan 2008 19:44:15 +0100 (CET)	[thread overview]
Message-ID: <18229.80.33.200.229.1201545855.squirrel@feanor.sssup.it> (raw)
In-Reply-To: <200801281021.57317.david-b@pacbell.net>

Hi,
> On Monday 28 January 2008, Haavard Skinnemoen wrote:
>> On Mon, 28 Jan 2008 12:15:00 +0100
>> michael <trimarchi@gandalf.sssup.it> wrote:
>>
>> > Hi,
>> > I implement a little patch (ndr just for a try) for the atmel serial
>> > driver atmel_serial.c to wakeup the system when it is in suspend-ram
>> state.
>> > I reconfigure the RXD pin as a gpio in suspend function and restore it
>> > in the resume function. It is the correct way?
>>
>> I'm not sure...this is rather platform-specific, so I don't think it
>> really belongs in the atmel_serial() driver. One solution might be to
>> add a function pointer to struct atmel_uart_data that the driver can
>> call from ->suspend() in order to let the platform code handle this as
>> appropriate.
>
> The core issue is that the system clock driving the baud rate generator
> is no longer running fast enough to let the UART run.  (In "standby" the
> clock is still driven by the PLL, so this issue doesn't come up.)  The
> GPIO logic can catch the START bit though ... this technique is used on
> some OMAP boards too.
>
> Agreed that knowing exactly which pin(s) should be remuxed (UARTn.RX to
> GPIO in suspend then enabling it as a wakeup irq, then reversing that
> on resume; maybe UARTn.DCD should work too..), and how (as A-peripheral?
> or  B?) is chip-specific knowledge.  Such a function pointer could work.
>
> What will AVR32 (AP7) need to do, when it supports system sleep states?
>
> - Dave
>
My code just works and I can try to implement a clean patches and submit to
the mailing list.

Michael


  reply	other threads:[~2008-01-28 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 11:15 michael
2008-01-28 13:56 ` Haavard Skinnemoen
2008-01-28 18:21   ` David Brownell
2008-01-28 18:44     ` trimarchi [this message]
2008-01-28 18:51     ` Haavard Skinnemoen
2008-01-30  0:37       ` michael
2008-01-30  3:44       ` David Brownell
2008-01-30 11:47         ` Haavard Skinnemoen
2008-01-30 18:56           ` David Brownell
2008-01-30 20:34             ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18229.80.33.200.229.1201545855.squirrel@feanor.sssup.it \
    --to=trimarchi@feanor.sssup.it \
    --cc=david-b@pacbell.net \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=trimarchi@gandalf.sssup.it \
    --subject='Re: at91sam9260 wakeup on serial port' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).