LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: akpm@linux-foundation.org, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Intro: convert lockd to kthread and fix use-after-free (try #7)
Date: Fri, 11 Jan 2008 12:37:24 +1100	[thread overview]
Message-ID: <18310.51284.272147.137400@notabene.brown> (raw)
In-Reply-To: message from Jeff Layton on Thursday January 10

On Thursday January 10, jlayton@redhat.com wrote:
> This is the seventh patchset to fix the use-after-free problem in lockd
 ....

This patch set looks good now.  I'm happy to give it a 

  Reviewed-by: NeilBrown <neilb@suse.de>

Two remaining issues that I would like to see address, but don't
necessarily need to be part of this set, are:

 1/ When the last nfsd thread dies, lockd should drop all locks, even
    if there are active nfs mounts.
    One approach might be:
      export nlmsvc_invalidate_all
      call it from nfsd_last_thread
      worry about how to change grace_period_expire.

 2/ get rid of svc_wake_up and ->b_daemon
    Maybe change b_daemon to b_rqstp and just call
	wake_up(&block->b_rqstp->rq_wait)

Thanks,
NeilBrown

      

      parent reply	other threads:[~2008-01-11  1:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 18:01 [PATCH 0/5] Intro: convert lockd to kthread and fix use-after-free (try #7) Jeff Layton
2008-01-10 18:01 ` [PATCH 1/5] SUNRPC: spin svc_rqst initialization to its own function Jeff Layton
2008-01-10 18:01   ` [PATCH 2/5] SUNRPC: export svc_sock_update_bufs Jeff Layton
2008-01-10 18:01     ` [PATCH 3/5] NLM: Have lockd call try_to_freeze Jeff Layton
2008-01-10 18:01       ` [PATCH 4/5] NLM: Convert lockd to use kthreads Jeff Layton
2008-01-10 18:01         ` [PATCH 5/5] NLM: have nlm_shutdown_hosts kill off all NLM RPC tasks Jeff Layton
2008-01-13 11:54       ` [PATCH 3/5] NLM: Have lockd call try_to_freeze Jeff Layton
2008-01-13 22:24         ` Neil Brown
2008-01-13 23:59           ` Rafael J. Wysocki
2008-01-11  1:37 ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18310.51284.272147.137400@notabene.brown \
    --to=neilb@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jlayton@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).