LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: avorontsov@ru.mvista.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Clemens Koller <clemens.koller@anagramm.de>,
	benh@kernel.crashing.org,
	linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
	Krzysztof Helt <krzysztof.h1@poczta.fm>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness
Date: Thu, 21 Feb 2008 15:59:44 +1100	[thread overview]
Message-ID: <18365.1344.466799.556560@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080220121818.GA20836@localhost.localdomain>

Anton Vorontsov writes:

> > I was wondering if it would be sufficient to provide alternative
> > versions of fb_readl, fb_writel etc. that do byte-swapping.
> 
> This is of course viable alternative. And I was considering this, but
> later I abandoned the idea: that way we'll end up doing math in the
> native endianness and then converting it to the foreign. This feels
> ugly in contrast when we can do the right math in the first place, per
> framebuffer.

OK.  I guess I'm convinced then.  However, your patch description
needs to be a lot better.  It should describe things like why you
want to make the change and why the change you are proposing is a good
idea and is better than other alternatives.  If you'd done that
originally we might not have needed to have all this discussion. :)

Paul.

  parent reply	other threads:[~2008-02-21  4:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 15:44 Anton Vorontsov
2008-02-05 19:07 ` Anton Vorontsov
2008-02-15  6:49 ` Andrew Morton
2008-02-15 16:45   ` Anton Vorontsov
2008-02-17  9:44     ` [Linux-fbdev-devel] " Geert Uytterhoeven
2008-02-18  7:18       ` Krzysztof Helt
2008-02-18 17:30         ` Valdis.Kletnieks
2008-02-18 17:37           ` Anton Vorontsov
2008-02-18 23:35           ` Clemens Koller
2008-02-19  0:35             ` Benjamin Herrenschmidt
2008-02-19 11:27               ` Clemens Koller
2008-02-19 12:05                 ` Andrew Morton
2008-02-19 12:22                   ` Clemens Koller
2008-02-20  0:47                   ` Valdis.Kletnieks
2008-02-20  0:50                     ` Benjamin Herrenschmidt
2008-02-20  0:56                   ` Paul Mackerras
2008-02-20 12:18                     ` Anton Vorontsov
2008-02-20 20:38                       ` Benjamin Herrenschmidt
2008-02-21  4:59                       ` Paul Mackerras [this message]
2008-02-20 15:43                     ` Clemens Koller
2008-02-16 11:49 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18365.1344.466799.556560@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=benh@kernel.crashing.org \
    --cc=clemens.koller@anagramm.de \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --subject='Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).