LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3] perf vendor events: Add metrics for Icelake Server
Date: Thu, 5 Aug 2021 13:42:56 +0800	[thread overview]
Message-ID: <1838b532-19b4-6f92-0057-d71bfa740a3c@linux.intel.com> (raw)
In-Reply-To: <CAP-5=fUGzso7f2rGG5_YkuOr72qY5EmkckDsayb47vLHxhJ9FQ@mail.gmail.com>

Hi Ian,

On 8/5/2021 1:09 PM, Ian Rogers wrote:
> Hi,
> 
> I'm not sure what's happening but when I generate this using:
> https://github.com/intel/event-converter-for-linux-perf
> 
> I see here:
>          "MetricExpr": "1 / IPC",
> 
> There are various other differences and so I've included the generated file.
> 
> Thanks,
> Ian

Please see following commit in event-converter-for-linux-perf repo.

commit b2265b953d57130a2ad8255d126bb69cf8552898
Author: Jin Yao <yao.jin@linux.intel.com>
Date:   Thu Jun 3 09:57:01 2021 +0800

     Don't expand inner metric if possible

     Before:

         {
             "MetricExpr": "1 / (INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD)",
             "BriefDescription": "Cycles Per Instruction (per Logical Processor)",
             "MetricGroup": "Pipeline",
             "MetricName": "CPI"
         },

     After:

         {
             "MetricExpr": "1 / IPC",
             "BriefDescription": "Cycles Per Instruction (per Logical Processor)",
             "MetricGroup": "Pipeline",
             "MetricName": "CPI"
         },

     We also provide a new option '--expr-events' for checking if it's a complex
     metric. For a simple metric, we probablly don't need to reuse the inner
     metric. For a complex metric, it's useful to reuse the inner metric.

I enable the option '--expr-events' when generating the metrics JSON. Since CPI is a simple metric, 
so the inner metric is still expanded.

For cstate metrics, only Core C1/C6 and Package C2/C6 are supported for ICX. The cstate metrics are 
appended manually right now.

Thanks
Jin Yao

      reply	other threads:[~2021-08-05  5:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  7:07 Jin Yao
2021-07-29  7:11 ` Jin, Yao
2021-08-05  1:18   ` Jin, Yao
2021-08-05  5:09     ` Ian Rogers
2021-08-05  5:42       ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1838b532-19b4-6f92-0057-d71bfa740a3c@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --subject='Re: [PATCH v3] perf vendor events: Add metrics for Icelake Server' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).