LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
@ 2018-04-24 13:17 Luc Van Oostenryck
  2018-04-24 14:49 ` Geert Uytterhoeven
  2018-04-24 16:36 ` Sergei Shtylyov
  0 siblings, 2 replies; 3+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:17 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Sergei Shtylyov, David S. Miller,
	Geert Uytterhoeven, Thomas Petazzoni, Laurent Pinchart,
	Simon Horman, Niklas Söderlund, netdev, linux-renesas-soc

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index b6b90a631..0875a169f 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -2454,7 +2454,7 @@ static void sh_eth_tx_timeout(struct net_device *ndev)
 }
 
 /* Packet transmit function */
-static int sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev)
+static netdev_tx_t sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	struct sh_eth_private *mdp = netdev_priv(ndev);
 	struct sh_eth_txdesc *txdesc;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
  2018-04-24 13:17 [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type Luc Van Oostenryck
@ 2018-04-24 14:49 ` Geert Uytterhoeven
  2018-04-24 16:36 ` Sergei Shtylyov
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-04-24 14:49 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: Linux Kernel Mailing List, Sergei Shtylyov, David S. Miller,
	Geert Uytterhoeven, Thomas Petazzoni, Laurent Pinchart,
	Simon Horman, Niklas Söderlund, netdev, Linux-Renesas

On Tue, Apr 24, 2018 at 3:17 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
  2018-04-24 13:17 [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type Luc Van Oostenryck
  2018-04-24 14:49 ` Geert Uytterhoeven
@ 2018-04-24 16:36 ` Sergei Shtylyov
  1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-04-24 16:36 UTC (permalink / raw)
  To: Luc Van Oostenryck, linux-kernel
  Cc: David S. Miller, Geert Uytterhoeven, Thomas Petazzoni,
	Laurent Pinchart, Simon Horman, Niklas Söderlund, netdev,
	linux-renesas-soc

Hello!

On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote:

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

[...]
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index b6b90a631..0875a169f 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2454,7 +2454,7 @@ static void sh_eth_tx_timeout(struct net_device *ndev)
>  }
>  
>  /* Packet transmit function */
> -static int sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> +static netdev_tx_t sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev)

   But aren't you violating 80-column limit?

[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-24 16:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:17 [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type Luc Van Oostenryck
2018-04-24 14:49 ` Geert Uytterhoeven
2018-04-24 16:36 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).