LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jarek Poplawski <jarkao2@o2.pl>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
Date: Tue, 20 Feb 2007 10:44:56 +0000	[thread overview]
Message-ID: <18581.1171968296@redhat.com> (raw)
In-Reply-To: <20070219221125.GA5070@tv-sign.ru>


Oleg Nesterov <oleg@tv-sign.ru> wrote:

>  static void release_nbp(struct kobject *kobj)
>  {
>  	struct net_bridge_port *p
>  		= container_of(kobj, struct net_bridge_port, kobj);
> +
> +	dev_put(p->dev);

Does this need to be done with the mutex held?  And does anything actually pay
attention to the refcount on dev?  I assume not...

Should you clear p->dev->br_port before calling dev_put()?

Looks reasonable.  I like it.

Acked-By: David Howells <dhowells@redhat.com>

  parent reply	other threads:[~2007-02-20 10:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-18 21:43 [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR Oleg Nesterov
2007-02-19 11:00 ` Jarek Poplawski
2007-02-19 12:03   ` Oleg Nesterov
2007-02-19 13:27     ` Jarek Poplawski
2007-02-19 15:04       ` Oleg Nesterov
2007-02-20 13:25         ` Jarek Poplawski
2007-02-20 14:25           ` Oleg Nesterov
2007-02-19 11:27 ` David Howells
2007-02-19 11:59   ` Oleg Nesterov
2007-02-19 22:11     ` PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check() Oleg Nesterov
2007-02-20 10:44     ` David Howells [this message]
2007-02-20 14:34       ` Oleg Nesterov
2007-02-19 13:15   ` [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR David Howells
2007-02-19 14:56     ` Oleg Nesterov
2007-02-19 15:15     ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18581.1171968296@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jarkao2@o2.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --subject='Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).