LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
	Keerthy <j-keerthy@ti.com>, Zhang Rui <rui.zhang@intel.com>,
	linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]
Date: Wed, 02 May 2018 18:20:59 +0200	[thread overview]
Message-ID: <1861949.NMJD6FHQNL@amdc3058> (raw)
In-Reply-To: <20180502154931.GS27619@mai>

On Wednesday, May 02, 2018 05:49:31 PM Daniel Lezcano wrote:
> On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Entry for Index 941 has one zero too much. Fix it.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> Good catch :)

Thanks. :)

> I'm curious, how did you spot it ?

While I was reading the driver code I've noticed that
omap5430_adc_to_temp[] and dra752_adc_to_temp[] look pretty
similar so I've diff-ed them to find the actual differences
(+ to see if one of the tables can be removed). One of such
differences was the line containing the incorrect entry.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

      reply	other threads:[~2018-05-02 16:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180502141432eucas1p1c85aa366979b73c59a46ec0c2f7ef8e6@eucas1p1.samsung.com>
2018-05-02 14:14 ` Bartlomiej Zolnierkiewicz
2018-05-02 15:44   ` Keerthy
2018-05-02 15:49   ` Daniel Lezcano
2018-05-02 16:20     ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1861949.NMJD6FHQNL@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).