From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: "Jan Engelhardt" <jengelh@computergmbh.de> Cc: casey@schaufler-ca.com, akpm@osdl.org, torvalds@osdl.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk Subject: Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules Date: Fri, 2 Nov 2007 20:50:46 +0200 Message-ID: <1865922a0711021150r351cf210x39deb70888365abf@mail.gmail.com> (raw) In-Reply-To: <Pine.LNX.4.64.0711011826470.24502@fbirervta.pbzchgretzou.qr> On 11/1/07, Jan Engelhardt <jengelh@computergmbh.de> wrote: > > On Nov 1 2007 17:54, Ahmed S. Darwish wrote: > >+ > >+static inline int isblank(char c) > >+{ > >+ return (c == ' ' || c == '\t'); > >+} > > Use isspace(). > isspace accepts newlines and carriage-returns too which is not accepted between elements of a one rule. > >+ for (i = 0; i < count && data[i]; i ++) > >... > >+ subjectstr[(*label_len) ++] = data[i]; > > i++ w/o space > Notes Taken. Thanks for the review. Regards, Darwish
prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-10-25 3:46 [PATCH 0/2] Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel Casey Schaufler 2007-10-26 14:57 ` Joshua Brindle 2007-10-27 13:57 ` Joshua Brindle 2007-10-27 18:47 ` Casey Schaufler 2007-11-01 15:54 ` [PATCH] Smackv9: Use a stateful parser for parsing Smack rules Ahmed S. Darwish 2007-11-01 17:29 ` Jan Engelhardt 2007-11-02 18:50 ` Ahmed S. Darwish [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1865922a0711021150r351cf210x39deb70888365abf@mail.gmail.com \ --to=darwish.07@gmail.com \ --cc=akpm@osdl.org \ --cc=casey@schaufler-ca.com \ --cc=jengelh@computergmbh.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=torvalds@osdl.org \ --cc=viro@ftp.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git