LKML Archive on
 help / color / Atom feed
From: "Ahmed S. Darwish" <>
To: "James Morris" <>
Cc: "Chris Wright" <>,
	"Stephen Smalley" <>,
	"Eric Paris" <>,
	"Casey Schaufler" <>,
	"Paul Moore" <>,
	"Alexey Dobriyan" <>,
	"Andrew Morton" <>,
	Linus <>,
	LKML <>,
	LSM-ML <>
Subject: Re: [PATCH -v8 -rc3] Security: Introduce security= boot parameter
Date: Thu, 6 Mar 2008 16:32:51 +0200
Message-ID: <> (raw)
In-Reply-To: <>

Hi James,

On Thu, Mar 6, 2008, James Morris <> wrote:
> On Thu, 6 Mar 2008, Ahmed S. Darwish wrote:
>  >     Handle Andrew's concerns:
>  >     - Use __init and __initdata in appropriate places.
>  >     - Do not rely upon dummy_ops layout, use C99 initializations.
>  >     - Use DEFINE_SPINLOCK instead of dynamic initialization.
>  The spinlock is not needed now, if security_module_enable() can only be
>  called during boot via an initcall.

Will do.

Would you mind answering my confusions below so I can do the change
with good understanding ?

I see preempt_disable() before calling security and vfs_caches init,
but what will prevent two processors/cores from executing
security_module_enable() concurrently (thus possibly corrupting
chosen_lsm) ?
security_module_enable() is also now used in __init init_smk_fs().

Or the init path got executed serially ?

Thank you,

Ahmed S. Darwish

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 12:19 Ahmed S. Darwish
2008-03-06 13:31 ` James Morris
2008-03-06 14:32   ` Ahmed S. Darwish [this message]
2008-03-06 15:03     ` James Morris
2008-03-06 16:09       ` [PATCH -v8b " Ahmed S. Darwish
2008-03-07  1:42         ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone