LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: "James Morris" <jmorris@namei.org>
Cc: "Chris Wright" <chrisw@sous-sol.org>,
	"Stephen Smalley" <sds@tycho.nsa.gov>,
	"Eric Paris" <eparis@parisplace.org>,
	"Casey Schaufler" <casey@schaufler-ca.com>,
	"Paul Moore" <paul.moore@hp.com>,
	"Alexey Dobriyan" <adobriyan@sw.ru>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	Linus <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LSM-ML <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH -v8 -rc3] Security: Introduce security= boot parameter
Date: Thu, 6 Mar 2008 16:32:51 +0200	[thread overview]
Message-ID: <1865922a0803060632kb63405fj3d255472fb2e555f@mail.gmail.com> (raw)
In-Reply-To: <Xine.LNX.4.64.0803070025440.16767@us.intercode.com.au>

Hi James,

On Thu, Mar 6, 2008, James Morris <jmorris@namei.org> wrote:
> On Thu, 6 Mar 2008, Ahmed S. Darwish wrote:
>
>  >     Handle Andrew's concerns:
>  >     - Use __init and __initdata in appropriate places.
>  >     - Do not rely upon dummy_ops layout, use C99 initializations.
>  >     - Use DEFINE_SPINLOCK instead of dynamic initialization.
>
>  The spinlock is not needed now, if security_module_enable() can only be
>  called during boot via an initcall.
>

Will do.

Would you mind answering my confusions below so I can do the change
with good understanding ?

I see preempt_disable() before calling security and vfs_caches init,
but what will prevent two processors/cores from executing
security_module_enable() concurrently (thus possibly corrupting
chosen_lsm) ?
security_module_enable() is also now used in __init init_smk_fs().

Or the init path got executed serially ?

Thank you,

-- 
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com

  reply	other threads:[~2008-03-06 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 12:19 Ahmed S. Darwish
2008-03-06 13:31 ` James Morris
2008-03-06 14:32   ` Ahmed S. Darwish [this message]
2008-03-06 15:03     ` James Morris
2008-03-06 16:09       ` [PATCH -v8b " Ahmed S. Darwish
2008-03-07  1:42         ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1865922a0803060632kb63405fj3d255472fb2e555f@mail.gmail.com \
    --to=darwish.07@gmail.com \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=casey@schaufler-ca.com \
    --cc=chrisw@sous-sol.org \
    --cc=eparis@parisplace.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul.moore@hp.com \
    --cc=sds@tycho.nsa.gov \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH -v8 -rc3] Security: Introduce security= boot parameter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).