LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: rajpat@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, rnayak@codeaurora.org,
	saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com,
	skakit@codeaurora.org
Subject: Re: [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes
Date: Tue, 31 Aug 2021 20:58:51 +0530	[thread overview]
Message-ID: <18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org> (raw)
In-Reply-To: <CAE-0n51YGqp701EzUs1Q1PG89SECVQDdUPsiJ8P95xFj0UFs=A@mail.gmail.com>

On 2021-08-26 23:41, Stephen Boyd wrote:
> Quoting Rajesh Patil (2021-08-26 06:15:30)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 7c106c0..65126a7 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -225,6 +225,10 @@
>>         status = "okay";
>>  };
>> 
>> +&qupv3_id_1 {
>> +       status = "okay";
>> +};
>> +
> 
> Why enable this here but not any of the i2c/spi/uart devices that are a
> child? Can this hunk be split off to a different patch?
> 

Currently there is no usecase on qup1 and hence not enabled.
Regarding splitting this, I did not get the exact reason why we need to 
split. This patch adds all the qup wrapper1 nodes and we are enabling it 
in board file.

>>  &sdhc_1 {
>>         status = "okay";
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index a3c11b0..32f411f 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2040,6 +2469,46 @@
>>                                 function = "qup07";
>>                         };
>> 
>> +                       qup_i2c8_data_clk:qup-i2c8-data-clk {
> 
> Unstick please.
> 

OKay.

>> +                               pins = "gpio32", "gpio33";
>> +                               function = "qup10";
>> +                       };
>> +
>> +                       qup_i2c9_data_clk:qup-i2c9-data-clk {
>> +                               pins = "gpio36", "gpio37";
>> +                               function = "qup11";
>> +                       };
>> +
>> +                       qup_i2c10_data_clk:qup-i2c10-data-clk {
>> +                               pins = "gpio40", "gpio41";
>> +                               function = "qup12";
>> +                       };
>> +
>> +                       qup_i2c11_data_clk:qup-i2c11-data-clk {
>> +                               pins = "gpio44", "gpio45";
>> +                               function = "qup13";
>> +                       };
>> +
>> +                       qup_i2c12_data_clk:qup-i2c12-data-clk {
>> +                               pins = "gpio48", "gpio49";
>> +                               function = "qup14";
>> +                       };
>> +
>> +                       qup_i2c13_data_clk:qup-i2c13-data-clk {
>> +                               pins = "gpio52", "gpio53";
>> +                               function = "qup15";
>> +                       };
>> +
>> +                       qup_i2c14_data_clk:qup-i2c14-data-clk {
>> +                               pins = "gpio56", "gpio57";
>> +                               function = "qup16";
>> +                       };
>> +
>> +                       qup_i2c15_data_clk:qup-i2c15-data-clk {
>> +                               pins = "gpio60", "gpio61";
>> +                               function = "qup17";
>> +                       };
> 
> All of these.
> 
>> +
>>                         qup_spi0_data_clk: qup-spi0-data-clk {
>>                                 pins = "gpio0", "gpio1", "gpio2";
>>                                 function = "qup00";

  reply	other threads:[~2021-08-31 15:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 13:15 [PATCH V6 0/7] Add QSPI and QUPv3 DT nodes for SC7280 SoC Rajesh Patil
2021-08-26 13:15 ` [PATCH V6 1/7] arm64: dts: sc7280: Add QSPI node Rajesh Patil
2021-08-26 18:02   ` Stephen Boyd
2021-08-31 15:29     ` rajpat
2021-08-26 13:15 ` [PATCH V6 2/7] arm64: dts: sc7280: Configure SPI-NOR FLASH for sc7280-idp Rajesh Patil
2021-08-26 18:03   ` Stephen Boyd
2021-08-26 13:15 ` [PATCH V6 3/7] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes Rajesh Patil
2021-08-26 18:06   ` Stephen Boyd
2021-08-31 15:28     ` rajpat
2021-08-26 20:08   ` Matthias Kaehlcke
2021-08-26 13:15 ` [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node Rajesh Patil
2021-08-26 21:01   ` Matthias Kaehlcke
2021-08-31 15:27     ` rajpat
2021-08-26 13:15 ` [PATCH V6 5/7] arm64: dts: sc7280: Configure uart7 to support bluetooth on sc7280-idp Rajesh Patil
2021-08-26 13:15 ` [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes Rajesh Patil
2021-08-26 18:11   ` Stephen Boyd
2021-08-31 15:28     ` rajpat [this message]
2021-09-01  5:04       ` Stephen Boyd
2021-08-26 13:15 ` [PATCH V6 7/7] arm64: dts: sc7280: Add aliases for I2C and SPI Rajesh Patil
2021-08-26 18:12   ` Stephen Boyd
2021-08-31 15:29     ` rajpat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org \
    --to=rajpat@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msavaliy@qti.qualcomm.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=skakit@codeaurora.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).