LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "bugme-daemon@kernel-bugs.osdl.org" 
	<bugme-daemon@bugzilla.kernel.org>,
	Truxton Fulton <trux@truxton.com>,
	linux-kernel@vger.kernel.org, lee-in-berlin@web.de
Subject: Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn't reboot with kernels > 2.6.13.5 (responsible commit found)
Date: Sat, 28 Apr 2007 13:23:17 +0200	[thread overview]
Message-ID: <18bbbf39d8da8a578ab7eab477f500c1@kernel.crashing.org> (raw)
In-Reply-To: <20070427144434.970de79f.akpm@linux-foundation.org>

That patch says

> +               outb(0x60, 0x64);       /* write Controller Command 
> Byte */
> +               udelay(50);
> +               kb_wait();
> +               udelay(50);
> +               outb(0x14, 0x60);       /* set "System flag" */

so the comment doesn't agree with the code: it sets
all flags in the command byte, not just the system
flag.  Perhaps importantly, it disables the keyboard
clock.  Why not do a read-modify-write sequence instead?
Something like

                outb(0x20, 0x64);       /* read Controller Command Byte 
*/
                udelay(50);
                kb_wait();
                udelay(50);
                u8 cmd = inb(0x60);
                udelay(50);
                kb_wait();
                udelay(50);
                outb(0x60, 0x64);       /* write Controller Command Byte 
*/
                udelay(50);
                kb_wait();
                udelay(50);
                outb(cmd | 0x04, 0x60); /* set "System flag" */

Segher


      parent reply	other threads:[~2007-04-28 11:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704271742.l3RHgPTH019561@fire-2.osdl.org>
2007-04-27 21:44 ` Andrew Morton
2007-04-28  3:17   ` Truxton Fulton
2007-05-12 19:35     ` Lee Garrett
2007-05-13  1:02       ` Andrew Morton
2007-05-13 12:13         ` Truxton Fulton
2007-10-03  2:30         ` Truxton Fulton
2007-11-01 15:50           ` Aristeu Rozanski
2007-11-01 17:53             ` Andrew Morton
2007-11-01 18:05               ` Aristeu Rozanski
2007-04-28 11:23   ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18bbbf39d8da8a578ab7eab477f500c1@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=lee-in-berlin@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trux@truxton.com \
    --subject='Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn'\''t reboot with kernels > 2.6.13.5 (responsible commit found)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).