LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kyle Moffett <mrmacman_g4@mac.com>
To: daw-usenet@taverner.cs.berkeley.edu (David Wagner)
Cc: linux-kernel@vger.kernel.org
Subject: Re: R: Linux kernel source archive vulnerable
Date: Wed, 13 Sep 2006 02:17:30 -0400	[thread overview]
Message-ID: <1BB4231A-7D69-4A77-A050-1C633BDFA545@mac.com> (raw)
In-Reply-To: <ee8589$e70$1@taverner.cs.berkeley.edu>

On Sep 13, 2006, at 01:34:01, David Wagner wrote:
> Willy Tarreau  wrote:
>> The initial reason is that Linus now uses the "git-tar-tree" command
>> which creates the full tar archive from the tree. It does not use  
>> tar,
>> it know how to produce the tar format itself. The command has to set
>> permissions on the files, and by default, it sets full permissions to
>> the files.
>
> Ahh, thanks for the explanation.  That's helpful.
>
> So it sounds like git-tar-tree has a bug; its default isn't setting
> meaningful permissions on the files that it puts into the tar archive.
> I hope the maintainers of git-tar-tree will consider fixing this bug.

Let me reiterate:  This is not a bug!

Here are a few facts:

1)  When I run "touch foo", the "touch" command uses permissions  
0666, which are modified by my umask before hitting the FS.  (same  
behavior for all UIDs)

2)  When I run "gcc -c foo.c -o foo.o", the "gcc" command uses  
permissions 0666, which are modified by my umask before hitting the  
FS.  (same behavior for all UIDs)

3)  When I run "vim foo.c", the "vim" command uses permissions 0666  
for new files, which are modified by my umask before hitting the FS.   
(same behavior for all UIDs)

4)  When I run "tar -xvf foo.tar" as a normal user, the "tar" command  
uses permissions from the archive for new files, which are modified  
by my umask before hitting the FS.

5)  Do you see the pattern here?


Now when I run that tar command as root, for some reason they assume  
that just because my UID is 0 I want to try to ignore my umask while  
extracting my j_random.tar file.  How does this follow from the  
behavior of any other programs mentioned above?

The program "git-tar-tree" has no bug.  It creates the tar archive  
such that when extracted as a normal user the users' umask is applied  
exactly as for every other standard program.  If anything the "bug"  
is in tar assuming that every archive file extracted as UID 0 is a  
backup, or in the admin assuming that tar doesn't behave differently  
when run as UID 0.

Cheers,
Kyle Moffett


  reply	other threads:[~2006-09-13  6:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060907182304.GA10686@danisch.de>
     [not found] ` <D432C2F98B6D1B4BAE47F2770FEFD6B612B8B7@to1mbxs02.replynet.prv>
2006-09-11 18:29   ` Jon Lewis
2006-09-12  5:06     ` Kyle Moffett
2006-09-12  5:27       ` Willy Tarreau
2006-09-12 19:42       ` R: " David Wagner
2006-09-12 20:35         ` linux-os (Dick Johnson)
2006-09-12 21:35           ` David Wagner
2006-09-12 22:56             ` Rene Scharfe
2006-09-13  1:17               ` David Wagner
2006-09-13  4:33                 ` Willy Tarreau
2006-09-13  5:34                   ` David Wagner
2006-09-13  6:17                     ` Kyle Moffett [this message]
2006-09-13  6:26                       ` David Wagner
2006-09-13  6:49                         ` Kyle Moffett
2006-09-13  6:59                           ` David Wagner
2006-09-13  8:12                             ` Kyle Moffett
2006-09-14 22:38                               ` David Wagner
2006-09-15  7:28                                 ` Stefan Richter
2006-09-13 10:45                         ` Martin Mares
2006-09-13 11:13                           ` Jan Engelhardt
2006-09-13  6:26                       ` Jan Engelhardt
2006-09-13 19:49                         ` Willy Tarreau
2006-09-13  8:51                 ` Stefan Richter
2006-09-14 23:04                 ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1BB4231A-7D69-4A77-A050-1C633BDFA545@mac.com \
    --to=mrmacman_g4@mac.com \
    --cc=daw-usenet@taverner.cs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: R: Linux kernel source archive vulnerable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).