LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] drm/tegra: plane: Implement zPos plane property for older Tegra's
Date: Fri, 4 May 2018 15:32:06 +0300	[thread overview]
Message-ID: <1a0c4c45-d4b1-3f3c-f804-deaa8458b652@gmail.com> (raw)
In-Reply-To: <20180504121530.GS13459@ulmo>

On 04.05.2018 15:15, Thierry Reding wrote:
> On Fri, May 04, 2018 at 03:08:43AM +0300, Dmitry Osipenko wrote:
>> Older Tegra's do not support planes z position handling in hardware,
>> but HW provides knobs for zPos implementation in software.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/gpu/drm/tegra/dc.c    | 134 ++++++++++++++++-------
>>  drivers/gpu/drm/tegra/plane.c | 193 ++++++++++++++++++++++++----------
>>  drivers/gpu/drm/tegra/plane.h |  13 ++-
>>  3 files changed, 244 insertions(+), 96 deletions(-)
> 
> This is obviously a lot to review, but it looks pretty good. On minor
> comment below.
> 
>> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
>> index 2e81142281c3..ba5481cd470d 100644
>> --- a/drivers/gpu/drm/tegra/dc.c
>> +++ b/drivers/gpu/drm/tegra/dc.c
>> @@ -162,29 +162,90 @@ static void tegra_plane_setup_blending_legacy(struct tegra_plane *plane)
> [...]
>> +		case 1:
>> +			/*
>> +			 * When both middle and topmost windows have an alpha,
>> +			 * these windows a mixed together and then the result
>> +			 * is blended over the bottom window.
>> +			 */
>> +			if ((state->blending[0].alpha &&
>> +			     state->blending[0].top))
> 
> There seems to be one pair of parentheses too much here.

Good catch ;)

  reply	other threads:[~2018-05-04 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  0:08 [PATCH v1 0/3] Couple more DRM plane features on Tegra Dmitry Osipenko
2018-05-04  0:08 ` [PATCH v1 1/3] drm/tegra: dc: Enable plane scaling filters Dmitry Osipenko
2018-05-04 11:10   ` Thierry Reding
2018-05-04 11:55     ` Dmitry Osipenko
2018-05-04 12:09       ` Thierry Reding
2018-05-04  0:08 ` [PATCH v1 2/3] drm/tegra: plane: Implement zPos plane property for older Tegra's Dmitry Osipenko
2018-05-04 12:15   ` Thierry Reding
2018-05-04 12:32     ` Dmitry Osipenko [this message]
2018-05-04  0:08 ` [PATCH v1 3/3] drm/tegra: dc: Rename supports_blending to has_legacy_blending Dmitry Osipenko
2018-05-04 12:16   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a0c4c45-d4b1-3f3c-f804-deaa8458b652@gmail.com \
    --to=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --subject='Re: [PATCH v1 2/3] drm/tegra: plane: Implement zPos plane property for older Tegra'\''s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).