LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Darren Hart <dvhart@infradead.org>
Cc: tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides
Date: Fri, 11 May 2018 09:25:22 -0600	[thread overview]
Message-ID: <1ab4e7fb-91af-e706-a6df-e7d9f16e21ae@kernel.org> (raw)
In-Reply-To: <20180511151320.GA6391@fury>

On 05/11/2018 09:13 AM, Darren Hart wrote:
> On Wed, May 02, 2018 at 03:18:45PM -0600, Shuah Khan (Samsung OSG) wrote:
>> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
>> lib.mk. Common defines work just fine and there is no need to define
>> custom overrides.
>>
>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
> 
> I was concerned because this override was a deliberate decision made in:
> 
> 9705315b7562 selftests/futex: Update Makefile to use lib.mk

Yes I had the same concern.
> 
> But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same
> function running TEST_PROGS.
> 
> Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
> 

Thanks. Yes I was surprised as well. I ran a few times to make sure. :)

-- Shuah

  reply	other threads:[~2018-05-11 15:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 21:18 [PATCH] selftests: android: " Shuah Khan (Samsung OSG)
2018-05-02 21:18 ` [PATCH] selftests: futex: " Shuah Khan (Samsung OSG)
2018-05-09  9:46   ` Anders Roxell
2018-05-11 15:13   ` Darren Hart
2018-05-11 15:25     ` Shuah Khan [this message]
2018-05-02 21:18 ` [PATCH] selftests: memory-hotplug: " Shuah Khan (Samsung OSG)
2018-05-09  9:46   ` Anders Roxell
2018-05-09 11:39   ` lei yang
2018-05-02 21:18 ` [PATCH] selftests: mount: " Shuah Khan (Samsung OSG)
2018-05-09  9:49   ` Anders Roxell
2018-05-02 21:18 ` [PATCH] selftests: mqueue: " Shuah Khan (Samsung OSG)
2018-05-09  9:49   ` Anders Roxell
2018-05-12 16:12 ` [PATCH] selftests: android: " Pintu Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ab4e7fb-91af-e706-a6df-e7d9f16e21ae@kernel.org \
    --to=shuah@kernel.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).