LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] spi: stm32: Fix error handling in stm32_spi_probe()
@ 2018-03-30 19:54 Alexey Khoroshilov
  2018-04-03  7:24 ` Amelie DELAUNAY
  2018-04-16 17:16 ` Applied "spi: stm32: Fix error handling in stm32_spi_probe()" to the spi tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Alexey Khoroshilov @ 2018-03-30 19:54 UTC (permalink / raw)
  To: Mark Brown, Amelie Delaunay, Maxime Coquelin, Alexandre Torgue
  Cc: Alexey Khoroshilov, linux-spi, linux-arm-kernel, linux-kernel,
	ldv-project

clk_get_rate() is below clk_prepare_enable(), so
its error should lead to goto err_clk_disable, not to err_master_put.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/spi/spi-stm32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index ba9743fa2326..ad1e55d3d5d5 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1129,7 +1129,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
 	if (!spi->clk_rate) {
 		dev_err(&pdev->dev, "clk rate = 0\n");
 		ret = -EINVAL;
-		goto err_master_put;
+		goto err_clk_disable;
 	}
 
 	spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-16 17:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 19:54 [PATCH] spi: stm32: Fix error handling in stm32_spi_probe() Alexey Khoroshilov
2018-04-03  7:24 ` Amelie DELAUNAY
2018-04-16 17:16 ` Applied "spi: stm32: Fix error handling in stm32_spi_probe()" to the spi tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).