LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Juergen Gross <jgross@suse.com>, Jason Andryuk <jandryuk@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	dmitry.torokhov@gmail.com, lyan@suse.com,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	andrii_chepurnyi@epam.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration
Date: Thu, 19 Apr 2018 16:22:53 +0300	[thread overview]
Message-ID: <1d737998-6b90-ba33-bafa-8a8d4dc568d8@gmail.com> (raw)
In-Reply-To: <d4075815-2b41-781d-3541-6a17a181512d@suse.com>

On 04/19/2018 04:19 PM, Juergen Gross wrote:
> On 19/04/18 15:12, Oleksandr Andrushchenko wrote:
>> On 04/19/2018 04:10 PM, Jason Andryuk wrote:
>>> On Thu, Apr 19, 2018 at 9:01 AM, Oleksandr Andrushchenko
>>> <andr2000@gmail.com> wrote:
>>>> Ok, so I'll send v2 with the following changes:
>>>>
>>>> diff --git a/drivers/input/misc/xen-kbdfront.c
>>>> b/drivers/input/misc/xen-kbdfront.c
>>>> index a3306aad40b0..d8cca212f737 100644
>>>> --- a/drivers/input/misc/xen-kbdfront.c
>>>> +++ b/drivers/input/misc/xen-kbdfront.c
>>>> @@ -51,13 +51,13 @@ module_param_array(ptr_size, int, NULL, 0444);
>>>>    MODULE_PARM_DESC(ptr_size,
>>>>           "Pointing device width, height in pixels (default 800,600)");
>>>>
>>>> -static unsigned int no_ptr_dev;
>>>> -module_param(no_ptr_dev, uint, 0);
>>>> +static bool no_ptr_dev;
>>>> +module_param(no_ptr_dev, bool, 0);
>>>>    MODULE_PARM_DESC(no_ptr_dev,
>>>>           "If set then no virtual pointing device exposed to the guest");
>>>>
>>>> -static unsigned int no_kbd_dev;
>>>> -module_param(no_kbd_dev, uint, 0);
>>>> +static bool no_kbd_dev;
>>>> +module_param(no_kbd_dev, bool, 0);
>>>>    MODULE_PARM_DESC(no_kbd_dev,
>>>>           "If set then no virtual keyboard device exposed to the guest");
>>> I prefer direct logic over inverse logic.  Maybe just use kbd_dev,
>>> default to true, but allow it to be set off?
>>>
>>> static bool kbd_dev = true;
>>> module_param(kbd_dev, bool, 0);
>> I have no preference here, either way works for me
>> Juergen, what do you think about the above?
> I really have no preference here. What should be taken into account is
> that boolean parameters don't need a value, meaning "true" in that case.
> This would make no sense for "kbd_dev" as it wouldn't change the
> default.
Then I'll go with the diff above, e.g. boolean no_{kbd|ptr})dev
> Juergen

  reply	other threads:[~2018-04-19 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 15:04 Oleksandr Andrushchenko
2018-04-19 11:25 ` Juergen Gross
2018-04-19 11:44   ` Oleksandr Andrushchenko
2018-04-19 12:52     ` Juergen Gross
2018-04-19 13:01       ` Oleksandr Andrushchenko
2018-04-19 13:10         ` [Xen-devel] " Jason Andryuk
2018-04-19 13:12           ` Oleksandr Andrushchenko
2018-04-19 13:19             ` Juergen Gross
2018-04-19 13:22               ` Oleksandr Andrushchenko [this message]
2018-04-23 18:53     ` Dmitry Torokhov
2018-04-24  5:55       ` Oleksandr Andrushchenko
2018-04-26 19:16         ` Dmitry Torokhov
2018-04-26 19:27           ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d737998-6b90-ba33-bafa-8a8d4dc568d8@gmail.com \
    --to=andr2000@gmail.com \
    --cc=andrii_chepurnyi@epam.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jandryuk@gmail.com \
    --cc=jgross@suse.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyan@suse.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).