From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA86C43331 for ; Fri, 3 Apr 2020 07:27:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEDB2206F8 for ; Fri, 3 Apr 2020 07:27:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="ptRdg/eo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388959AbgDCH07 (ORCPT ); Fri, 3 Apr 2020 03:26:59 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:15717 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730889AbgDCH07 (ORCPT ); Fri, 3 Apr 2020 03:26:59 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48ts282dk9z9vBLM; Fri, 3 Apr 2020 09:26:56 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=ptRdg/eo; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id q7_0R8FodDcJ; Fri, 3 Apr 2020 09:26:56 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48ts281Ly7z9vBLL; Fri, 3 Apr 2020 09:26:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1585898816; bh=G/gE+3SR1+TZN2RTMUhJh+L+wYW4d0v6JEe81BP7dDo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ptRdg/eo9tW40fi+LHGtu5aDnwLwI2aX5PP7bewfPrpMSzpgGlJvE1yeNnHxxyqSR 2tQhGDeucgvb4b2+NyrAETGvtbXpRvazSbkKpkouiR7rDWL6307CWs+C8BTSEh2dHv exsrh+i4rtv0rLsI/kvEbENe44ABNAZpCM/aIT3M= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 064FF8B943; Fri, 3 Apr 2020 09:26:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id wpdS4NRykvtP; Fri, 3 Apr 2020 09:26:56 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id BABD88B75B; Fri, 3 Apr 2020 09:26:54 +0200 (CEST) Subject: Re: [PATCH v11 0/8] Disable compat cruft on ppc64le v11 To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Michal Suchanek Cc: Arnaldo Carvalho de Melo , Alexander Shishkin , Allison Randal , Andy Shevchenko , Arnd Bergmann , Thiago Jung Bauermann , Benjamin Herrenschmidt , Sebastian Andrzej Siewior , Claudio Carvalho , "David S. Miller" , "Eric W. Biederman" , Eric Richter , Greg Kroah-Hartman , Gustavo Luiz Duarte , Hari Bathini , Jordan Niethe , Jiri Olsa , Jonathan Cameron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Mauro Carvalho Chehab , Michael Neuling , Ingo Molnar , Michael Ellerman , Namhyung Kim , Nayna Jain , Paul Mackerras , Peter Zijlstra , Rob Herring , Thomas Gleixner , Valentin Schneider , Alexander Viro References: <20200225173541.1549955-1-npiggin@gmail.com> <1585898335.tckaz04a6x.astroid@bobo.none> From: Christophe Leroy Message-ID: <1e00a725-9710-2b80-4aff-2f284b31d2e5@c-s.fr> Date: Fri, 3 Apr 2020 09:26:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1585898335.tckaz04a6x.astroid@bobo.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/04/2020 à 09:25, Nicholas Piggin a écrit : > Michal Suchanek's on March 19, 2020 10:19 pm: >> Less code means less bugs so add a knob to skip the compat stuff. >> >> Changes in v2: saner CONFIG_COMPAT ifdefs >> Changes in v3: >> - change llseek to 32bit instead of builing it unconditionally in fs >> - clanup the makefile conditionals >> - remove some ifdefs or convert to IS_DEFINED where possible >> Changes in v4: >> - cleanup is_32bit_task and current_is_64bit >> - more makefile cleanup >> Changes in v5: >> - more current_is_64bit cleanup >> - split off callchain.c 32bit and 64bit parts >> Changes in v6: >> - cleanup makefile after split >> - consolidate read_user_stack_32 >> - fix some checkpatch warnings >> Changes in v7: >> - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek >> - remove leftover hunk >> - add review tags >> Changes in v8: >> - consolidate valid_user_sp to fix it in the split callchain.c >> - fix build errors/warnings with PPC64 !COMPAT and PPC32 >> Changes in v9: >> - remove current_is_64bit() >> Chanegs in v10: >> - rebase, sent together with the syscall cleanup >> Changes in v11: >> - rebase >> - add MAINTAINERS pattern for ppc perf > > These all look good to me. I had some minor comment about one patch but > not really a big deal and there were more cleanups on top of it, so I > don't mind if it's merged as is. > > Actually I think we have a bit of stack reading fixes for 64s radix now > (not a bug fix as such, but we don't need the hash fault logic in radix), > so if I get around to that I can propose the changes in that series. > As far as I can see, there is a v12 Christophe