LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions
@ 2021-08-11  8:20 Huilong Deng
  2021-08-11  8:58 ` Vladimir Murzin
  0 siblings, 1 reply; 2+ messages in thread
From: Huilong Deng @ 2021-08-11  8:20 UTC (permalink / raw)
  To: linux, ira.weiny, sfr, akpm; +Cc: linux-arm-kernel, linux-kernel, Huilong Deng

./arch/arm/mm/nommu.c:59:8-9: WARNING: return of 0/1 in function
'security_extensions_enabled' with return type bool

Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
---
 arch/arm/mm/nommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 2658f52903da..7256ac159acb 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
 	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
 		return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
 			cpuid_feature_extract(CPUID_EXT_PFR1, 20);
-	return 0;
+	return false;
 }
 
 unsigned long setup_vectors_base(void)
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions
  2021-08-11  8:20 [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions Huilong Deng
@ 2021-08-11  8:58 ` Vladimir Murzin
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Murzin @ 2021-08-11  8:58 UTC (permalink / raw)
  To: Huilong Deng, linux, ira.weiny, sfr, akpm; +Cc: linux-arm-kernel, linux-kernel

On 8/11/21 9:20 AM, Huilong Deng wrote:
> ./arch/arm/mm/nommu.c:59:8-9: WARNING: return of 0/1 in function
> 'security_extensions_enabled' with return type bool
> 
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
> ---
>  arch/arm/mm/nommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52903da..7256ac159acb 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
>  	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
>  		return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
>  			cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> -	return 0;
> +	return false;
>  }
>  
>  unsigned long setup_vectors_base(void)
> 

Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>

Please, submit it into RMK's Patch system [1]

[1] https://www.armlinux.org.uk/developer/patches/

Cheers
Vladimir

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-11  8:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11  8:20 [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions Huilong Deng
2021-08-11  8:58 ` Vladimir Murzin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).