LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Nicolas Schier <n.schier@avm.de>
Cc: linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: allow "make" targets 'versioncheck' and 'includecheck' withoug .config file
Date: Fri, 13 Aug 2021 08:00:59 -0700	[thread overview]
Message-ID: <1ecfeb81-a2e4-a177-1886-11e4ffc54224@infradead.org> (raw)
In-Reply-To: <YRYuC9p5G714Bt68@deb-nschier.ads.avm.de>

On 8/13/21 1:32 AM, Nicolas Schier wrote:
> On Wed, Aug 11, 2021 at 03:54:42PM -0700, Randy Dunlap wrote:
>> Top-level Makefile targets 'versioncheck' and 'includecheck' don't
>> need a configured kernel (i.e., don't need a .config file), so add
>> them the the list of "no-dot-config-targets".
>> This eliminates the 'make' error:
>>
>> ***
>> *** Configuration file ".config" not found!
>> ***
>> *** Please run some configurator (e.g. "make oldconfig" or
>> *** "make menuconfig" or "make xconfig").
>> ***
>> Makefile:759: include/config/auto.conf.cmd: No such file or directory
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Cc: Michal Marek <michal.lkml@markovi.net>
>> Cc: linux-kbuild@vger.kernel.org
>> ---
> 
> I like that change, works for me as expected.  Possibly you might want
> to fix the commit subject typo (withoug -> without).
> 

Yes, I noticed that a few minutes after I sent it, but I guess
that this patch isn't going anywhere.

Thanks.

> 
> 
>> Fixes: I couldn't determine this.
>>
>>   Makefile |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> --- linux-next-20210811.orig/Makefile
>> +++ linux-next-20210811/Makefile
>> @@ -274,7 +274,8 @@ no-dot-config-targets := $(clean-targets
>>   			 cscope gtags TAGS tags help% %docs check% coccicheck \
>>   			 $(version_h) headers headers_% archheaders archscripts \
>>   			 %asm-generic kernelversion %src-pkg dt_binding_check \
>> -			 outputmakefile rustfmt rustfmtcheck
>> +			 outputmakefile rustfmt rustfmtcheck \
>> +			 versioncheck includecheck
>>   # Installation targets should not require compiler. Unfortunately, vdso_install
>>   # is an exception where build artifacts may be updated. This must be fixed.
>>   no-compiler-targets := $(no-dot-config-targets) install dtbs_install \


-- 
~Randy


      reply	other threads:[~2021-08-13 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 22:54 [PATCH] kbuild: allow "make" targets 'versioncheck' and 'includecheck' withoug .config file Randy Dunlap
2021-08-13  7:27 ` Masahiro Yamada
2021-08-13  8:32 ` Nicolas Schier
2021-08-13 15:00   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ecfeb81-a2e4-a177-1886-11e4ffc54224@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=n.schier@avm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).