LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ram Chandrasekar <rkumbako@codeaurora.org>
To: Lina Iyer <ilina@codeaurora.org>, Zhang Rui <rui.zhang@intel.com>
Cc: edubezval@gmail.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] drivers: thermal: do not clobber cooling dev state from userspace
Date: Wed, 22 Aug 2018 10:48:27 -0600	[thread overview]
Message-ID: <1fa9d64d-0f52-dba2-8777-799fa9272581@codeaurora.org> (raw)
In-Reply-To: <20180814180447.GJ5081@codeaurora.org>



On 8/14/2018 12:04 PM, Lina Iyer wrote:
> Adding Ram, so he can respond.
> -- Lina
> 
> On Thu, Jul 26 2018 at 02:55 -0600, Zhang Rui wrote:
>> On 一, 2018-05-07 at 11:55 -0600, Lina Iyer wrote:
>>> From: Ram Chandrasekar <rkumbako@codeaurora.org>
>>>
>>> Let userspace be another voter for cooling device state instead of
>>> the
>>> overriding authority. It is possible that the thermal governor may
>>> find
>>> a higher cooling state desirable than what is recommended by the
>>> userspace. Separate out the current cooling device state from the
>>> userspace request and aggregate the userspace request with the
>>> governors' recommendation.
>>>
>>
>> hmmm, I don't understand this.
>> If the governor does not work well, we should either improve the
>> governor or use userspace governor instead.
>> do you have any examples that the kernel governor chooses improper
>> cooling state?
>>
Userspace governor and kernel governor could monitor different thermal 
zones for different thermal conditions and mitigate the same cooling 
device. In this case, the cooling device state request from userspace 
governor shouldn’t overwrite the request from kernel governor, rather it 
needs to be aggregated. This change is to aggregate the cooling device 
state requests between the userspace and kernel governors.

Thanks,
Ram

      reply	other threads:[~2018-08-22 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 17:55 Lina Iyer
2018-07-26  8:55 ` Zhang Rui
2018-08-14 18:04   ` Lina Iyer
2018-08-22 16:48     ` Ram Chandrasekar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fa9d64d-0f52-dba2-8777-799fa9272581@codeaurora.org \
    --to=rkumbako@codeaurora.org \
    --cc=edubezval@gmail.com \
    --cc=ilina@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH] drivers: thermal: do not clobber cooling dev state from userspace' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).