LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: Alexander Viro <viro@math.psu.edu>, Jan Kara <jack@ucw.cz>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-xfs@oss.sgi.com
Subject: Re: Quotactl change
Date: Mon, 8 Oct 2001 13:19:18 +1100	[thread overview]
Message-ID: <20011008131918.Y472533@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <20011006150731.C30450@atrey.karlin.mff.cuni.cz> <Pine.GSO.4.21.0110061417260.6465-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0110061417260.6465-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Sat, Oct 06, 2001 at 02:25:06PM -0400

hi Al,

On Sat, Oct 06, 2001 at 02:25:06PM -0400, Alexander Viro wrote:
> On Sat, Oct 06, 2001 at 03:07:32PM +0200, Jan Kara wrote:
> >   I'm sending you a change for quotactl interface which Nathan
> > Scott proposed for XFS. Actually it's his patch with just a few
> > changes from me.
> >   It allows quotactl() to be overidden by a filesystem and so XFS
> > can do it's tricks with quota without patching dquot.c. Sideeffect
> > of this change is a cleanup in quotactl() interface :).
> 
> [snip]
> 
> 	Umm...  So you've just given to each fs driver a syscall with
> completely unspecified arguments?  I _really_ doubt that it's a good
> idea, especially since each instance will have to copy structures
> to/from userland.
> 
> 	Please, put switch by the first argument and copy_{to,from}_user()
> into the syscall itself.  Yes, it means more methods, but it helps to avoid
> large PITA couple of years down the road.
> 

OK, if that's for the best, I'll rework it.  I thought it would
be cleaner to do it that other way, because it meant not having
any knowledge of the filesystem-specific quota data structures
and operations up at this higher (vfs) level.  Since ioctl is
available as a generic copy in/out facility already, I'm not
sure why any filesystem would abuse quotactl in this way, but
perhaps that's just human nature. ;-)

The only other reason that I was thinking of - I expect that 
Veritas' VxFS will also wish to provide its own quota subsystem,
as they seem to do for other operating systems.  Since (and I may
be wrong here) the intention there is to make VxFS a commercial
filesystem for Linux, it would also help those folk out if the
point of doing the user data copying was within the filesystem.
So, I was trying to do the right thing by everyone in making it
generic - your suggestion will work just fine for our needs in
XFS though.

Thanks for the feedback - new patch later.

cheers.

-- 
Nathan

  reply	other threads:[~2001-10-08  2:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-06 13:07 Jan Kara
2001-10-06 18:25 ` Alexander Viro
2001-10-08  2:19   ` Nathan Scott [this message]
2001-10-08 10:34   ` Nathan Scott
2001-10-09  7:03     ` Alexander Viro
2001-10-09  7:34     ` Jan Kara
2001-10-09 12:21       ` Nathan Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011008131918.Y472533@wobbly.melbourne.sgi.com \
    --to=nathans@sgi.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jack@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=viro@math.psu.edu \
    --subject='Re: Quotactl change' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).