LKML Archive on
help / color / mirror / Atom feed
From: Jan Kara <>
To: Nathan Scott <>
Cc: Alexander Viro <>,
	Alan Cox <>,,
Subject: Re: Quotactl change
Date: Tue, 9 Oct 2001 09:34:25 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> <> <>
In-Reply-To: <>


> Al - is the attached patch more along the lines of what you
> were after?
> Jan - I think this is actually alot closer to what you were
> talking about when we last discussed this.  Can you see any
> problems from a VFS quota point of view here?  I had to make
> small interface changes to a couple of the dquot.c routines
> to make this simpler/more uniform in places - could you have
> cross-check those for me?
  I see two problems:

1) You changed interface do dquot_sync() - so you should also
   change DQUOT_SYNC() macro in quotaops.h (rename argument) and
   all callers of DQUOT_SYNC() macro...

2) It seems to me that validate_quotactl() will actually never return
   superblock - instead of 'ret = 0;' there should be 'return sb;'
   and that test 'if (ret)' should be removed....


  parent reply	other threads:[~2001-10-09  7:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-06 13:07 Jan Kara
2001-10-06 18:25 ` Alexander Viro
2001-10-08  2:19   ` Nathan Scott
2001-10-08 10:34   ` Nathan Scott
2001-10-09  7:03     ` Alexander Viro
2001-10-09  7:34     ` Jan Kara [this message]
2001-10-09 12:21       ` Nathan Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: Quotactl change' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).